[GitHub] [cloudstack] shwstppr commented on a change in pull request #5181: vmware, ui: update portgroup on network offering change

[GitBox <gi...@apache.org>]

shwstppr commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r704222279



##########
File path: server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
##########
@@ -97,6 +98,24 @@
     public static ConfigKey<Boolean> VmMinCpuSpeedEqualsCpuSpeedDividedByCpuOverprovisioningFactor = new ConfigKey<Boolean>("Advanced", Boolean.class, "vm.min.cpu.speed.equals.cpu.speed.divided.by.cpu.overprovisioning.factor", "true",
             "If we set this to 'true', a minimum CPU speed (cpu speed/ cpu.overprovisioning.factor) will be set on the VM, independent of using a scalable service offering or not.", true, ConfigKey.Scope.Cluster);
 
+    private Map<NetworkOffering.Detail, String> getNicDetails(Network network) {
+        Map<NetworkOffering.Detail, String> details = null;
+        if (network != null) {

Review comment:
       @GutoVeronezi done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org