You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/03/26 02:43:39 UTC

[GitHub] [netbeans] pepness opened a new pull request #2831: [NETBEANS-5503] Update JUnit from 4.13.1 to 4.13.2

pepness opened a new pull request #2831:
URL: https://github.com/apache/netbeans/pull/2831


   Notes:
   - Update all junit4 old references to junit-4.13.2
   - Add missing public packages to project.xml file
   
   NetBeans Testing:
   - Full build done
   - Verify successfull execution of libraries and licenses Ant test
   - Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS
   - Checked the files are in the Ant Library Manager
   - Clean, build and Test an Ant project with JUnit4 tests
   - Check working javadoc and sources
   ![NETBEANS-5503](https://user-images.githubusercontent.com/9832133/112569912-f2289700-8ddc-11eb-8476-e0efd3d46504.png)
   
   [JUnit4 Web Page](https://junit.org/junit4/)
   [Release Notes](https://github.com/junit-team/junit4/blob/HEAD/doc/ReleaseNotes4.13.2.md)
   
   I will squash the commits before merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] codeschnell commented on pull request #2831: [NETBEANS-5503] Update JUnit from 4.13.1 to 4.13.2

Posted by GitBox <gi...@apache.org>.
codeschnell commented on pull request #2831:
URL: https://github.com/apache/netbeans/pull/2831#issuecomment-982269595


   I'm not able to figure out the group id ,artifact id and version of my rs2xml.jar file.I have added it to my project made using Add Dependencies in apache netbeans 12.5.Can someone please help me figure it out?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] pepness commented on a change in pull request #2831: [NETBEANS-5503] Update JUnit from 4.13.1 to 4.13.2

Posted by GitBox <gi...@apache.org>.
pepness commented on a change in pull request #2831:
URL: https://github.com/apache/netbeans/pull/2831#discussion_r603717046



##########
File path: apisupport/apisupport.ant/src/org/netbeans/modules/apisupport/project/universe/ModuleList.java
##########
@@ -857,7 +857,7 @@ public boolean accept(File pathname) {
         static final String CNB = "org.netbeans.libs.junit4";
         JUnitPlaceholderEntry(File root) {
             super(CNB, new File(root, "platform/modules/" + CNB.replace('.', '-') + ".jar"),
-                    new File[] {new File(System.getProperty("user.home"), ".m2/repository/junit/junit/4.8.2/junit-4.8.2.jar")},
+                    new File[] {new File(System.getProperty("user.home"), ".m2/repository/junit/junit/4.8.2/junit-4.13.2.jar")},

Review comment:
       Fixed, thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] pepness commented on pull request #2831: [NETBEANS-5503] Update JUnit from 4.13.1 to 4.13.2

Posted by GitBox <gi...@apache.org>.
pepness commented on pull request #2831:
URL: https://github.com/apache/netbeans/pull/2831#issuecomment-810746054


   Commits squashed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] jtulach commented on a change in pull request #2831: [NETBEANS-5503] Update JUnit from 4.13.1 to 4.13.2

Posted by GitBox <gi...@apache.org>.
jtulach commented on a change in pull request #2831:
URL: https://github.com/apache/netbeans/pull/2831#discussion_r602034459



##########
File path: platform/libs.junit4/nbproject/project.xml
##########
@@ -26,24 +26,45 @@
             <code-name-base>org.netbeans.libs.junit4</code-name-base>
             <module-dependencies/>
             <public-packages>
+                <package>org.hamcrest</package>
+                <package>org.hamcrest.core</package>
+                <package>org.hamcrest.internal</package>
                 <package>junit.extensions</package>
                 <package>junit.framework</package>
                 <package>junit.runner</package>
                 <package>junit.textui</package>
-                <package>org.hamcrest</package>
-                <package>org.hamcrest.core</package>
                 <package>org.junit</package>
+                <package>org.junit.experimental</package>
+                <package>org.junit.experimental.categories</package>
+                <package>org.junit.experimental.max</package>
+                <package>org.junit.experimental.results</package>
+                <package>org.junit.experimental.runners</package>
+                <package>org.junit.experimental.theories</package>
+                <package>org.junit.experimental.theories.internal</package>
+                <package>org.junit.experimental.theories.suppliers</package>
+                <package>org.junit.function</package>
+                <package>org.junit.internal</package>

Review comment:
       Why do you think the module should expose `internal` packages?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #2831: [NETBEANS-5503] Update JUnit from 4.13.1 to 4.13.2

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2831:
URL: https://github.com/apache/netbeans/pull/2831#issuecomment-811525531


   Well, I'd revert the merge commit and instead of merge, rebase it from master then force push your branch. That way it is far more easy to merge this back to master (with github's rebase and merge)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] sdedic commented on a change in pull request #2831: [NETBEANS-5503] Update JUnit from 4.13.1 to 4.13.2

Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2831:
URL: https://github.com/apache/netbeans/pull/2831#discussion_r603262139



##########
File path: apisupport/apisupport.ant/src/org/netbeans/modules/apisupport/project/universe/ModuleList.java
##########
@@ -857,7 +857,7 @@ public boolean accept(File pathname) {
         static final String CNB = "org.netbeans.libs.junit4";
         JUnitPlaceholderEntry(File root) {
             super(CNB, new File(root, "platform/modules/" + CNB.replace('.', '-') + ".jar"),
-                    new File[] {new File(System.getProperty("user.home"), ".m2/repository/junit/junit/4.8.2/junit-4.8.2.jar")},
+                    new File[] {new File(System.getProperty("user.home"), ".m2/repository/junit/junit/4.8.2/junit-4.13.2.jar")},

Review comment:
       Shouldn't the parent directory's name (seems version of the artifact) change, too ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] pepness merged pull request #2831: [NETBEANS-5503] Update JUnit from 4.13.1 to 4.13.2

Posted by GitBox <gi...@apache.org>.
pepness merged pull request #2831:
URL: https://github.com/apache/netbeans/pull/2831


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] sdedic commented on pull request #2831: [NETBEANS-5503] Update JUnit from 4.13.1 to 4.13.2

Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2831:
URL: https://github.com/apache/netbeans/pull/2831#issuecomment-810024728


   @pepness mark with 12.4 milestone, if you want to release it :) for sure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] pepness commented on pull request #2831: [NETBEANS-5503] Update JUnit from 4.13.1 to 4.13.2

Posted by GitBox <gi...@apache.org>.
pepness commented on pull request #2831:
URL: https://github.com/apache/netbeans/pull/2831#issuecomment-812074314


   @lkishalmi revert the last commit to recover the full history of activities, i.e., commits?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] pepness commented on a change in pull request #2831: [NETBEANS-5503] Update JUnit from 4.13.1 to 4.13.2

Posted by GitBox <gi...@apache.org>.
pepness commented on a change in pull request #2831:
URL: https://github.com/apache/netbeans/pull/2831#discussion_r602645729



##########
File path: platform/libs.junit4/nbproject/project.xml
##########
@@ -26,24 +26,45 @@
             <code-name-base>org.netbeans.libs.junit4</code-name-base>
             <module-dependencies/>
             <public-packages>
+                <package>org.hamcrest</package>
+                <package>org.hamcrest.core</package>
+                <package>org.hamcrest.internal</package>
                 <package>junit.extensions</package>
                 <package>junit.framework</package>
                 <package>junit.runner</package>
                 <package>junit.textui</package>
-                <package>org.hamcrest</package>
-                <package>org.hamcrest.core</package>
                 <package>org.junit</package>
+                <package>org.junit.experimental</package>
+                <package>org.junit.experimental.categories</package>
+                <package>org.junit.experimental.max</package>
+                <package>org.junit.experimental.results</package>
+                <package>org.junit.experimental.runners</package>
+                <package>org.junit.experimental.theories</package>
+                <package>org.junit.experimental.theories.internal</package>
+                <package>org.junit.experimental.theories.suppliers</package>
+                <package>org.junit.function</package>
+                <package>org.junit.internal</package>

Review comment:
       My bad, I did not check the javadoc to see what packages should be exposed. I have rectified the packages that should be exposed as per the [javadoc](https://junit.org/junit4/javadoc/latest/index.html)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists