You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/09 23:45:02 UTC
[GitHub] [airflow] khalidmammadov opened a new pull request #18865: Clean test_user once assert is complete
khalidmammadov opened a new pull request #18865:
URL: https://github.com/apache/airflow/pull/18865
Fixing a test that leaves "test user" in the database once testing is finished.
It moves out a test function from fixture to a generator function to make use generators for auto cleaning
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18865: Clean test_user once assert is complete
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18865:
URL: https://github.com/apache/airflow/pull/18865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov closed pull request #18865: Clean test_user once assert is complete
Posted by GitBox <gi...@apache.org>.
khalidmammadov closed pull request #18865:
URL: https://github.com/apache/airflow/pull/18865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov commented on pull request #18865: Clean test_user once assert is complete
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on pull request #18865:
URL: https://github.com/apache/airflow/pull/18865#issuecomment-941193248
Reopening as it was closed automatically by rebase action for some reason... The only diff I added is a small docstring to mark a change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov closed pull request #18865: Clean test_user once assert is complete
Posted by GitBox <gi...@apache.org>.
khalidmammadov closed pull request #18865:
URL: https://github.com/apache/airflow/pull/18865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr edited a comment on pull request #18865: Clean test_user once assert is complete
Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on pull request #18865:
URL: https://github.com/apache/airflow/pull/18865#issuecomment-940455782
Tests failed due to timeout, unrelated (the Postgres one actually reached cleanup but still ran out of time)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18865: Clean test_user once assert is complete
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18865:
URL: https://github.com/apache/airflow/pull/18865#issuecomment-940455782
Tests failed due to timeout (the Postgres one actually reached cleanup but still ran out of time)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18865: Clean test_user once assert is complete
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18865:
URL: https://github.com/apache/airflow/pull/18865#issuecomment-940455391
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18865: Clean test_user once assert is complete
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18865:
URL: https://github.com/apache/airflow/pull/18865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov commented on pull request #18865: Clean test_user once assert is complete
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on pull request #18865:
URL: https://github.com/apache/airflow/pull/18865#issuecomment-941193248
Reopening as it was closed automatically by rebase action for some reason... The only diff I added is a small docstring to mark a change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org