You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 14:49:30 UTC
[GitHub] [arrow] pitrou opened a new pull request #9125: ARROW-11162: [C++][Parquet] Fix invalid cast on Decimal256 Parquet data
pitrou opened a new pull request #9125:
URL: https://github.com/apache/arrow/pull/9125
The invalid cast would occur when a variable-length bytearray field would be
decoded as Decimal256 Arrow data.
Should fix the following issue:
- https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=28750
Found by OSS-Fuzz.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou edited a comment on pull request #9125: ARROW-11162: [C++][Parquet] Fix invalid cast on Decimal256 Parquet data
Posted by GitBox <gi...@apache.org>.
pitrou edited a comment on pull request #9125:
URL: https://github.com/apache/arrow/pull/9125#issuecomment-756162418
@emkornfield It appears the case this PR fixes (ByteArray -> Decimal256) isn't tested currently, though the ByteArray -> Decimal128 case is tested. It's the same code path, but still.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #9125: ARROW-11162: [C++][Parquet] Fix invalid cast on Decimal256 Parquet data
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #9125:
URL: https://github.com/apache/arrow/pull/9125
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9125: ARROW-11162: [C++][Parquet] Fix invalid cast on Decimal256 Parquet data
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9125:
URL: https://github.com/apache/arrow/pull/9125#issuecomment-758865641
Travis-CI build: https://travis-ci.com/github/pitrou/arrow/builds/212858874
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou edited a comment on pull request #9125: ARROW-11162: [C++][Parquet] Fix invalid cast on Decimal256 Parquet data
Posted by GitBox <gi...@apache.org>.
pitrou edited a comment on pull request #9125:
URL: https://github.com/apache/arrow/pull/9125#issuecomment-758808425
The AppVeyor failure is probably due to https://bugs.python.org/issue38091 - which is fixed in Python 3.9, but has not been backported.
(edit: this comment is outdated as I've restarted the AppVeyor build and it now shows an unrelated integration failure with the foreign `s3fs` package)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9125: ARROW-11162: [C++][Parquet] Fix invalid cast on Decimal256 Parquet data
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9125:
URL: https://github.com/apache/arrow/pull/9125#issuecomment-756162418
@emkornfield It appears the code path this PR fixes (ByteArray -> Decimal256) isn't tested currently, though the ByteArray -> Decimal128 is tested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9125: ARROW-11162: [C++][Parquet] Fix invalid cast on Decimal256 Parquet data
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9125:
URL: https://github.com/apache/arrow/pull/9125#issuecomment-758808425
The AppVeyor failure is probably due to https://bugs.python.org/issue38091 - which is fixed in Python 3.9, but has not been backported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9125: ARROW-11162: [C++][Parquet] Fix invalid cast on Decimal256 Parquet data
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9125:
URL: https://github.com/apache/arrow/pull/9125#issuecomment-756162245
https://issues.apache.org/jira/browse/ARROW-11162
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #9125: ARROW-11162: [C++][Parquet] Fix invalid cast on Decimal256 Parquet data
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #9125:
URL: https://github.com/apache/arrow/pull/9125#issuecomment-756389248
LGTM. I'll add a test for decimal256 (I thought this was covered by our some of the templated tests, I'll figure try to figure out why it wasn't).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9125: ARROW-11162: [C++][Parquet] Fix invalid cast on Decimal256 Parquet data
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9125:
URL: https://github.com/apache/arrow/pull/9125#issuecomment-758788270
I've added a test, will merge if green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org