You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2023/04/04 15:01:59 UTC

[GitHub] [netbeans] sdedic opened a new pull request, #5773: Better handling for dependencies w/o versions

sdedic opened a new pull request, #5773:
URL: https://github.com/apache/netbeans/pull/5773

   Consider dependency declaration as follows:
   ```
   dependencies {
           implementation 'org.springframework.boot:spring-boot-starter-web'
           developmentOnly 'org.springframework.boot:spring-boot-devtools'
           testImplementation 'org.springframework.boot:spring-boot-starter-test'
   }
   ```
   there's no version specified for `spring-boot-devtools.
   
   The [https://github.com/apache/netbeans/blob/master/extide/gradle/netbeans-gradle-tooling/src/main/java/org/netbeans/modules/gradle/tooling/NbProjectInfoBuilder.java#L1502](code that reports `developmentOnly_directChildren`) handles such situations using GAV without version (as specified in the buildfile) - `org.springframework.boot:spring-boot-devtools:`. 
   
   The issue is that when **resolved** artifacts GAVs are matched against these direct children, the module dependency with resolved version is not matched to the version-less child. So I have added a path that attempts to strip a version and match again.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] sdedic merged pull request #5773: Better handling for dependencies w/o versions

Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic merged PR #5773:
URL: https://github.com/apache/netbeans/pull/5773


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists