You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by André Malo <nd...@perlig.de> on 2003/01/16 17:09:59 UTC
Re: Review desired - mod_ident
* Justin Erenkrantz wrote:
> --On Wednesday, January 15, 2003 2:32 AM +0100 André Malo
> <nd...@perlig.de> wrote:
>
>> I'd like to let someone review before committing, because it's at
>> least a bunch of core changes.
>
> Looks good upon cursory review. I think we could optimize some of
> the socket calls (short read/write cases), but that was there before.
> We could always clean that up later. (sscanf - ugh!)
>
> My only real complaint is the tabs/formatting. =) There seem to be
> lots of whitespace issues. (Again, there before, but we ought to
> clean it up when we place it in the new location.)
ah well, c&p from rfc1413.c ;-)
I'll run a tab killer and whitespace cleanup before committing. For better
reproducing of the changes, I think, the code cleanup is better to apply
later.
Another question: I guess, the change does require an MMN bump, doesn't it?
nd
--
Da fällt mir ein, wieso gibt es eigentlich in Unicode kein
"i" mit einem Herzchen als Tüpfelchen? Das wär sooo süüss!
-- Björn Höhrmann in darw
Re: Review desired - mod_ident
Posted by André Malo <nd...@perlig.de>.
* Justin Erenkrantz wrote:
> --On Thursday, January 16, 2003 5:09 PM +0100 André Malo
> <nd...@perlig.de> wrote:
>
>> Another question: I guess, the change does require an MMN bump,
>> doesn't it?
>
> Well, I'm not real sure if we consider core_dir_config a part of our
> public structures. I really don't see why a module would be playing
> around in there.
Oh, I didn't think about the core_dir_config. I thought about the (then)
missing ap_rfc1413 function (and the global timeout variable, anyway).
nd
--
print "Just Another Perl Hacker";
# André Malo, <http://www.perlig.de/> #
Re: Review desired - mod_ident
Posted by Greg Ames <gr...@apache.org>.
Justin Erenkrantz wrote:
> --On Thursday, January 16, 2003 5:09 PM +0100 André Malo <nd...@perlig.de>
> wrote:
>
>> Another question: I guess, the change does require an MMN bump,
>> doesn't it?
>
>
> Well, I'm not real sure if we consider core_dir_config a part of our
> public structures. I really don't see why a module would be playing
> around in there.
>
> Anyone? -- justin
I agree with Justin. IMO any core_*_config is private to the core. I recall us
putting stuff in the core_request_config to keep it out of the request_rec for
example. Dunno if any modules are being bad.
Greg
Re: Review desired - mod_ident
Posted by Justin Erenkrantz <je...@apache.org>.
--On Thursday, January 16, 2003 5:09 PM +0100 André Malo
<nd...@perlig.de> wrote:
> Another question: I guess, the change does require an MMN bump,
> doesn't it?
Well, I'm not real sure if we consider core_dir_config a part of our
public structures. I really don't see why a module would be playing
around in there.
Anyone? -- justin