[GitHub] [guacamole-server] jmuehlner commented on a diff in pull request #388: GUACAMOLE-1540: Manual build all core protocol libraries for Docker image using Alpine Linux base.

[GitBox <gi...@apache.org>]

jmuehlner commented on code in PR #388:
URL: https://github.com/apache/guacamole-server/pull/388#discussion_r946206976


##########
src/guacd-docker/bin/list-dependencies.sh:
##########
@@ -35,19 +35,12 @@ while [ -n "$1" ]; do
     ldd "$1" | grep -v 'libguac' | awk '/=>/{print $(NF-1)}' \
         | while read LIBRARY; do
 
-        # In some cases, the library that's linked against is a hard link
-        # to the file that's managed by the package, which dpkg doesn't understand.
-        # Searching by */basename ensures the package will be found in these cases.
-        LIBRARY_BASENAME=$(basename "$LIBRARY")

Review Comment:
   I'm glad we don't need this anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org