You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/14 09:22:22 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6068: driver/mmcsdio: do not hold the semaphore on interrupt context
xiaoxiang781216 opened a new pull request, #6068:
URL: https://github.com/apache/incubator-nuttx/pull/6068
## Summary
so we can do the full dump to mmc/sd card in the panic case
## Impact
It's possible to call sdio_dev_s in panic handler
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6068: driver/mmcsdio: do not hold the semaphore on interrupt context
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6068:
URL: https://github.com/apache/incubator-nuttx/pull/6068#discussion_r850304334
##########
drivers/mmcsd/mmcsd_sdio.c:
##########
@@ -256,7 +256,7 @@ static int mmcsd_takesem(FAR struct mmcsd_state_s *priv)
* waiting)
*/
- if (up_interrupt_context() == false)
+ if (up_interrupt_context() == false && !sched_idletask())
Review Comment:
Done.
##########
drivers/mmcsd/mmcsd_sdio.c:
##########
@@ -282,7 +282,7 @@ static int mmcsd_takesem(FAR struct mmcsd_state_s *priv)
static void mmcsd_givesem(FAR struct mmcsd_state_s *priv)
{
- if (up_interrupt_context() == false)
+ if (up_interrupt_context() == false && !sched_idletask())
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6068: driver/mmcsdio: do not hold the semaphore on interrupt context
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6068:
URL: https://github.com/apache/incubator-nuttx/pull/6068#discussion_r850291259
##########
drivers/mmcsd/mmcsd_sdio.c:
##########
@@ -282,7 +282,7 @@ static int mmcsd_takesem(FAR struct mmcsd_state_s *priv)
static void mmcsd_givesem(FAR struct mmcsd_state_s *priv)
{
- if (up_interrupt_context() == false)
+ if (up_interrupt_context() == false && !sched_idletask())
Review Comment:
```suggestion
if (!up_interrupt_context() && !sched_idletask())
```
##########
drivers/mmcsd/mmcsd_sdio.c:
##########
@@ -256,7 +256,7 @@ static int mmcsd_takesem(FAR struct mmcsd_state_s *priv)
* waiting)
*/
- if (up_interrupt_context() == false)
+ if (up_interrupt_context() == false && !sched_idletask())
Review Comment:
```suggestion
if (!up_interrupt_context() && !sched_idletask())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6068: driver/mmcsdio: do not hold the semaphore on interrupt context
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6068:
URL: https://github.com/apache/incubator-nuttx/pull/6068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org