You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2017/10/13 16:29:29 UTC
[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8272
Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem
......................................................................
IMPALA-6049: breakpad tests: skip all tests with local filesystem
The breakpad tests were recently refactored to support inclusion of one
of them as a core test. In this refactor, we neglected to ensure
setup_class() called its parent. This means the skipping called in said
parent doesn't occur, and the test is executed in an unsupported
environment (local filesystem).
This patch fixes that by ensuring we call the parent setup_class() via
super().
Testing:
$ TARGET_FILESYSTEM="local" impala-py.test tests/custom_cluster/test_breakpad.py \
-k test_abort_writes_minidump
tests/custom_cluster/test_breakpad.py::TestBreakpadCore::test_abort_writes_minidump
SKIPPED
Change-Id: Ib4a3ff29dd85c79c4c3b3e3afb699861e408aa95
---
M tests/custom_cluster/test_breakpad.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/8272/1
--
To view, visit http://gerrit.cloudera.org:8080/8272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4a3ff29dd85c79c4c3b3e3afb699861e408aa95
Gerrit-Change-Number: 8272
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 )
Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing this. I fixed it in the same way but couldn't get a local build+test to run for unrelated reasons.
--
To view, visit http://gerrit.cloudera.org:8080/8272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a3ff29dd85c79c4c3b3e3afb699861e408aa95
Gerrit-Change-Number: 8272
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Oct 2017 17:09:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 )
Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem
......................................................................
Patch Set 1:
If you would like me to perform a file TARGET_FILESYSTEM="local" build+test, let me know, but it's pretty clear what the problem was and that the skipping works now.
--
To view, visit http://gerrit.cloudera.org:8080/8272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a3ff29dd85c79c4c3b3e3afb699861e408aa95
Gerrit-Change-Number: 8272
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Oct 2017 16:30:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 )
Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a3ff29dd85c79c4c3b3e3afb699861e408aa95
Gerrit-Change-Number: 8272
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 14 Oct 2017 01:02:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8272 )
Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem
......................................................................
IMPALA-6049: breakpad tests: skip all tests with local filesystem
The breakpad tests were recently refactored to support inclusion of one
of them as a core test. In this refactor, we neglected to ensure
setup_class() called its parent. This means the skipping called in said
parent doesn't occur, and the test is executed in an unsupported
environment (local filesystem).
This patch fixes that by ensuring we call the parent setup_class() via
super().
Testing:
$ TARGET_FILESYSTEM="local" impala-py.test tests/custom_cluster/test_breakpad.py \
-k test_abort_writes_minidump
tests/custom_cluster/test_breakpad.py::TestBreakpadCore::test_abort_writes_minidump
SKIPPED
Change-Id: Ib4a3ff29dd85c79c4c3b3e3afb699861e408aa95
Reviewed-on: http://gerrit.cloudera.org:8080/8272
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/custom_cluster/test_breakpad.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sailesh Mukil: Looks good to me, but someone else must approve
Lars Volker: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4a3ff29dd85c79c4c3b3e3afb699861e408aa95
Gerrit-Change-Number: 8272
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 )
Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1335/
--
To view, visit http://gerrit.cloudera.org:8080/8272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a3ff29dd85c79c4c3b3e3afb699861e408aa95
Gerrit-Change-Number: 8272
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Oct 2017 17:13:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 )
Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1336/
--
To view, visit http://gerrit.cloudera.org:8080/8272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a3ff29dd85c79c4c3b3e3afb699861e408aa95
Gerrit-Change-Number: 8272
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Oct 2017 21:06:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 )
Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a3ff29dd85c79c4c3b3e3afb699861e408aa95
Gerrit-Change-Number: 8272
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Oct 2017 16:44:37 +0000
Gerrit-HasComments: No