DO NOT REPLY [Bug 36037] - Allow query strings and anchors when returning forwards from Action

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=36037>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36037





------- Additional Comments From chris@christopherschultz.net  2006-01-12 23:24 -------
On the advice of Mr. Brown (see comment #11), I tried using ActionRedirect in
place of the class that I have written and attached to this bug.

I like the ActionRedirect, but I find it lacking in two ways:

1. It requires that an HTTP redirect be done (i.e. no forwarding to another
action on the server side with no client interaction)
2. The addParameter method returns void, so calls cannot be chained easily, like
this:

    return new ActionRedirect(mapping.findForward("success")
                .addParameter("foo", bar)
                .addParameter("baz", bat)
                ;

As for #1, one can certainly call ActionRedirect.setRedirect(false), but it
would be nice to use the setting defined in the struts config file to determine
the redirect flag.

Point #2 is easily rectified... simply return "this" from the
ActionRedirect.addParameter method.

I would like to propose that these changes be made, and I would be glad to
submit a patch. However, #1 is a pretty significant change, so I would like to
ask anyone who reads this message to give me some feedback... would a new class
be better (such as the one I have already attached to the bug), or should these
changes be made to the existing ActionRedirect class?

Thanks,
-chris

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org