You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/01 15:11:15 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests

cloud-fan commented on a change in pull request #31387:
URL: https://github.com/apache/spark/pull/31387#discussion_r567898359



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/TruncateTableSuite.scala
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v2
+
+import org.apache.spark.sql.AnalysisException
+import org.apache.spark.sql.execution.command
+
+/**
+ * The class contains tests for the `TRUNCATE TABLE` command to check V2 table catalogs.
+ */
+class TruncateTableSuite extends command.TruncateTableSuiteBase with CommandSuiteBase {
+
+  // TODO(SPARK-34290): Support v2 TRUNCATE TABLE

Review comment:
       The v2 API is ready, and this should be easy to do?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org