You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/04/05 19:18:39 UTC

[GitHub] [incubator-mxnet] szha opened a new pull request #20127: [PIP] set osx deploy target for v1.x wheels

szha opened a new pull request #20127:
URL: https://github.com/apache/incubator-mxnet/pull/20127


   Signed-off-by: Sheng Zha <zh...@amazon.com>
   
   ## Description ##
   set osx deploy target for v1.x wheels
   
   ## Checklist ##
   ### Essentials ###
   - [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage
   - [x] Code is well-documented
   
   ### Changes ###
   - [x] set osx deploy target for v1.x wheels
   
   ## Comments ##
   - This PR includes half of #19110 that hasn't been ported yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20127: [PIP] set osx deploy target for v1.x wheels

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20127:
URL: https://github.com/apache/incubator-mxnet/pull/20127#issuecomment-814171238


   Jenkins CI successfully triggered : [unix-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20127: [PIP] set osx deploy target for v1.x wheels

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20127:
URL: https://github.com/apache/incubator-mxnet/pull/20127#issuecomment-813588859


   Hey @szha , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [centos-gpu, windows-gpu, unix-gpu, website, miscellaneous, windows-cpu, centos-cpu, unix-cpu, clang, edge, sanity]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu merged pull request #20127: [PIP] set osx deploy target for v1.x wheels

Posted by GitBox <gi...@apache.org>.
leezu merged pull request #20127:
URL: https://github.com/apache/incubator-mxnet/pull/20127


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20127: [PIP] set osx deploy target for v1.x wheels

Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20127:
URL: https://github.com/apache/incubator-mxnet/pull/20127#discussion_r607283950



##########
File path: tools/staticbuild/build_lib_cmake.sh
##########
@@ -30,7 +30,12 @@ git submodule update --init --recursive || true
 
 # Build libmxnet.so
 rm -rf build; mkdir build; cd build
-cmake -GNinja -C $cmake_config -DCMAKE_PREFIX_PATH=${DEPS_PATH} -DCMAKE_FIND_ROOT_PATH=${DEPS_PATH} ..
+cmake \
+    -GNinja \
+    -C $cmake_config \
+    -DCMAKE_PREFIX_PATH=${DEPS_PATH} \
+    -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13 \

Review comment:
       Duplicate?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on a change in pull request #20127: [PIP] set osx deploy target for v1.x wheels

Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20127:
URL: https://github.com/apache/incubator-mxnet/pull/20127#discussion_r607358142



##########
File path: tools/staticbuild/build_lib_cmake.sh
##########
@@ -30,7 +30,12 @@ git submodule update --init --recursive || true
 
 # Build libmxnet.so
 rm -rf build; mkdir build; cd build
-cmake -GNinja -C $cmake_config -DCMAKE_PREFIX_PATH=${DEPS_PATH} -DCMAKE_FIND_ROOT_PATH=${DEPS_PATH} ..
+cmake \
+    -GNinja \
+    -C $cmake_config \
+    -DCMAKE_PREFIX_PATH=${DEPS_PATH} \
+    -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13 \

Review comment:
       should have no harm.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20127: [PIP] set osx deploy target for v1.x wheels

Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20127:
URL: https://github.com/apache/incubator-mxnet/pull/20127#discussion_r607386552



##########
File path: tools/staticbuild/build_lib_cmake.sh
##########
@@ -30,7 +30,12 @@ git submodule update --init --recursive || true
 
 # Build libmxnet.so
 rm -rf build; mkdir build; cd build
-cmake -GNinja -C $cmake_config -DCMAKE_PREFIX_PATH=${DEPS_PATH} -DCMAKE_FIND_ROOT_PATH=${DEPS_PATH} ..
+cmake \
+    -GNinja \
+    -C $cmake_config \
+    -DCMAKE_PREFIX_PATH=${DEPS_PATH} \
+    -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13 \

Review comment:
       If there's no benefit, there's no need to add the code. It will just serve to confuse readers




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #20127: [PIP] set osx deploy target for v1.x wheels

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20127:
URL: https://github.com/apache/incubator-mxnet/pull/20127#issuecomment-814171163


   @mxnet-bot run ci [unix-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org