You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by MichaelArthurAnderson <gi...@git.apache.org> on 2018/01/03 23:04:25 UTC
[GitHub] climate pull request #477: CLIMATE-826 ValueError in model_ensemble_to_rcmed...
GitHub user MichaelArthurAnderson opened a pull request:
https://github.com/apache/climate/pull/477
CLIMATE-826 ValueError in model_ensemble_to_rcmed.py
CLIMATE-826 ValueError in model_ensemble_to_rcmed.py
- Corrected start date / end date when bounds is created post re-bin.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MichaelArthurAnderson/climate CLIMATE-826
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/477.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #477
----
commit 17df0236c56e75d8c3e65282dd281958f100f5ad
Author: Michael Anderson <mi...@...>
Date: 2018-01-03T22:55:23Z
CLIMATE-826
----
---
[GitHub] climate pull request #477: CLIMATE-826 ValueError in model_ensemble_to_rcmed...
Posted by MichaelArthurAnderson <gi...@git.apache.org>.
Github user MichaelArthurAnderson closed the pull request at:
https://github.com/apache/climate/pull/477
---
[GitHub] climate pull request #477: CLIMATE-826 ValueError in model_ensemble_to_rcmed...
Posted by MichaelArthurAnderson <gi...@git.apache.org>.
Github user MichaelArthurAnderson commented on a diff in the pull request:
https://github.com/apache/climate/pull/477#discussion_r161935915
--- Diff: examples/model_ensemble_to_rcmed.py ---
@@ -125,6 +125,11 @@
wrf311_dataset, temporal_resolution='annual')
cru31_dataset = dsp.temporal_rebin(cru31_dataset, temporal_resolution='annual')
+# Rebinning annual pushes the start date to the middle of the year
--- End diff --
The example has 1 year of data. 1/1/1989 to 12/31/1989.
The data is then rebinned to annual.
That I believe that effectively pushes all the data to a single point a 7/2/1989.
I reset start date to the start date post rebinning. Setting the end date to the start date was easiest, but I could have set it to the end date on the data set, but I believe that would have been 7/2/1989 too.
---
[GitHub] climate pull request #477: CLIMATE-826 ValueError in model_ensemble_to_rcmed...
Posted by huikyole <gi...@git.apache.org>.
Github user huikyole commented on a diff in the pull request:
https://github.com/apache/climate/pull/477#discussion_r161660107
--- Diff: examples/model_ensemble_to_rcmed.py ---
@@ -125,6 +125,11 @@
wrf311_dataset, temporal_resolution='annual')
cru31_dataset = dsp.temporal_rebin(cru31_dataset, temporal_resolution='annual')
+# Rebinning annual pushes the start date to the middle of the year
--- End diff --
This example has not been updated for a while, but start_time = end_time does not make any sense. I will take a look at this example again.
---
[GitHub] climate pull request #477: CLIMATE-826 ValueError in model_ensemble_to_rcmed...
Posted by huikyole <gi...@git.apache.org>.
Github user huikyole commented on a diff in the pull request:
https://github.com/apache/climate/pull/477#discussion_r163141416
--- Diff: examples/model_ensemble_to_rcmed.py ---
@@ -125,6 +125,11 @@
wrf311_dataset, temporal_resolution='annual')
cru31_dataset = dsp.temporal_rebin(cru31_dataset, temporal_resolution='annual')
+# Rebinning annual pushes the start date to the middle of the year
--- End diff --
The original script compares the annual means for the year 1989 between cru (observation), two models, and an average of the models. I think using the start and end times of (1989, 1, 1) and (1989, 12, 1) are totally okay and drawing three plots for the three model datasets is reasonable.
---