You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/19 02:40:53 UTC

[GitHub] [apisix-dashboard] dogrod opened a new issue, #2434: Feature request: support regex_uri attribute in redirect plugin

dogrod opened a new issue, #2434:
URL: https://github.com/apache/apisix-dashboard/issues/2434

   # Feature request
   
   ## Please describe your feature
   
   ![image](https://user-images.githubusercontent.com/21096842/163909354-3047b871-dc2e-42d9-8af5-a4f78065a3e2.png)
   
   APISIX already supports uri attribute in redirect plugin, which is under "custom" option in "Name And Description" section. But in some more complex situations, regex_uri would be a better way.
   
   ## Describe the solution you'd like
   
   ![image](https://user-images.githubusercontent.com/21096842/163909476-a694b8de-2471-48d1-8b0e-2a877cb50a2f.png)
   
   Add regex_uri support just like the proxy_rewrite plugin.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-dashboard] guoqqqi commented on issue #2434: Feature request: support regex_uri attribute in redirect plugin

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on issue #2434:
URL: https://github.com/apache/apisix-dashboard/issues/2434#issuecomment-1203370312

   > I'm completing it, should I change the Redirect from the select to a radio, or add a new option on the original basis?
   
   hello, that's too abstract, can you add a diagram to show what you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2434: Feature request: support regex_uri attribute in redirect plugin

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on issue #2434:
URL: https://github.com/apache/apisix-dashboard/issues/2434#issuecomment-1103348444

   Hi @dogrod, thank you for your report. Would you like to help improve this feature?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-dashboard] Sh1-5 commented on issue #2434: Feature request: support regex_uri attribute in redirect plugin

Posted by GitBox <gi...@apache.org>.
Sh1-5 commented on issue #2434:
URL: https://github.com/apache/apisix-dashboard/issues/2434#issuecomment-1203486797

   > > I'm completing it, should I change the Redirect from the select to a radio, or add a new option on the original basis?
   > 
   > hello, that's too abstract, can you add a diagram to show what you think?
   1.select
   <img width="430" alt="image" src="https://user-images.githubusercontent.com/48705798/182527532-726f41ef-5bf4-4c01-adc1-ee545632e2c6.png">
   <img width="1127" alt="image" src="https://user-images.githubusercontent.com/48705798/182527595-ef0429ce-ac68-46f2-af01-2294624d5d78.png">
   
   2.radio, like this
   <img width="800" alt="image" src="https://user-images.githubusercontent.com/48705798/182527735-b487b883-e1d6-415f-8841-e8dc295f9b8d.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-dashboard] hanzhenfang commented on issue #2434: Feature request: support regex_uri attribute in redirect plugin

Posted by GitBox <gi...@apache.org>.
hanzhenfang commented on issue #2434:
URL: https://github.com/apache/apisix-dashboard/issues/2434#issuecomment-1119217296

   let me try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-dashboard] Sh1-5 commented on issue #2434: Feature request: support regex_uri attribute in redirect plugin

Posted by GitBox <gi...@apache.org>.
Sh1-5 commented on issue #2434:
URL: https://github.com/apache/apisix-dashboard/issues/2434#issuecomment-1203844070

   > hi, @Sh1-5 I prefer the latter. When we select Custom, we can add two radio configurations, one for `uri` by default and one for `regex_uri`. you can refer to [redirect](https://apisix.apache.org/docs/apisix/plugins/redirect/) , Looking forward to your PR~
   
   ok, I have completed it.It's time to write the test case


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-dashboard] guoqqqi commented on issue #2434: Feature request: support regex_uri attribute in redirect plugin

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on issue #2434:
URL: https://github.com/apache/apisix-dashboard/issues/2434#issuecomment-1203524374

   hi, @Sh1-5 
   I prefer the latter. When we select Custom, we can add two radio configurations, one for `uri` by default and one for `regex_uri`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-dashboard] Sh1-5 commented on issue #2434: Feature request: support regex_uri attribute in redirect plugin

Posted by GitBox <gi...@apache.org>.
Sh1-5 commented on issue #2434:
URL: https://github.com/apache/apisix-dashboard/issues/2434#issuecomment-1202088033

   I'm completing it, should I change the Redirect from the select to a radio, or add a new option on the original basis?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-dashboard] guoqqqi commented on issue #2434: Feature request: support regex_uri attribute in redirect plugin

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on issue #2434:
URL: https://github.com/apache/apisix-dashboard/issues/2434#issuecomment-1119217003

   ping @hanzhenfang Are you interested in completing it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org