You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/01/20 19:05:16 UTC
[GitHub] [mynewt-core] vikrant-proxy opened a new pull request #2458: crypto/tinycrypt: Update library to master
vikrant-proxy opened a new pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-763938693
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-764504927
looks good to me, but since there was no release could you put upstream commit hash in commit message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-764889095
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-763965386
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-763966024
@mkiiskila , @nkaje can you guys please take a look as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-763938693
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-770841918
hmm looks like this broke Security Manager tests in nimble host...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-763965386
@vikrant-proxy Great find. I was involved in the process so I will let others comment on it as well. I think we need these fixes, specially the cbc mode fix. It is small but critical. These are probably needed in mcuboot as well as nimble. I will let @utzig and @sjanc decide. I think it would be nice to open a PR to the respective repos as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] utzig commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
utzig commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-770844384
> hmm looks like this broke Security Manager tests in nimble host...
Try reverting the RNG changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vikrant-proxy commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
vikrant-proxy commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-764956405
> looks good to me, but since there was no release could you put upstream commit hash in commit message?
@sjanc updated the commit message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-770950487
OK, it was RNG. I've updated LE SC unit tests to not provide custom RNG callback. That way we don't need to change test data.
https://github.com/apache/mynewt-nimble/pull/908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-763868366
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vikrant-proxy commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
vikrant-proxy commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-764956405
> looks good to me, but since there was no release could you put upstream commit hash in commit message?
@sjanc updated the commit message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane merged pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-763938693
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-763868366
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-763868366
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on pull request #2458: crypto/tinycrypt: Update library to master
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #2458:
URL: https://github.com/apache/mynewt-core/pull/2458#issuecomment-764504927
looks good to me, but since there was no release could you put upstream commit hash in commit message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org