[GitHub] [helix] desaikomal commented on a diff in pull request #2486: Small bug fixes related to ZK disconnect and timeouts

["desaikomal (via GitHub)" <gi...@apache.org>]

desaikomal commented on code in PR #2486:
URL: https://github.com/apache/helix/pull/2486#discussion_r1194357431


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -1968,7 +1968,7 @@ public <T> T retryUntilConnected(final Callable<T> callable)
     if (_monitor != null) {
       _monitor.increaseOutstandingRequestGauge();
     }
-    int retryCount = 1;
+    int retryCount = 0;

Review Comment:
   Earlier and now too, we retry. The only difference is after failure, how long do we wait. Prior to exponential back-off, we didn't wait at all. Now we wait for whatever is the time ExponentialBackOff strategy calculates.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org