You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2017/04/27 15:10:01 UTC
Review Request 58801: Unify repository file creation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58801/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Bugs: AMBARI-20871
https://issues.apache.org/jira/browse/AMBARI-20871
Repository: ambari
Description
-------
We have 2 different ways of creating repositories - one is creating a new file for each repo definition (standard installation) and one file containing multiple repo definitions (install_packages). These should both be done the same way (the install_packages way).
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 8c726a0f2d
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 74a2cf2e32
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/DistributeRepositoriesStructuredOutput.java 662b856c05
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 3681eda976
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d556b603a8
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java ab8b65968e
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java e39588ed42
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 811ce9b8cb
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java fdb7c8d9b8
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 33adce1414
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 6193c11c22
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py a35dce757e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 8f7b31ddea
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 4bed482f8d
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java c6ee87588c
ambari-server/src/test/python/custom_actions/TestInstallPackages.py 77e3bee3f6
ambari-server/src/test/python/custom_actions/configs/install_packages_repository_file.json PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/configs/repository_file.json PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 082d2001cf
Diff: https://reviews.apache.org/r/58801/diff/1/
Testing
-------
Manual for both centos6 and ubuntu14. Automated pending.
Thanks,
Nate Cole
Re: Review Request 58801: Unify repository file creation
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58801/#review173211
-----------------------------------------------------------
Fix it, then Ship it!
ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
Lines 86 (patched)
<https://reviews.apache.org/r/58801/#comment246268>
is that intended?
- Dmitro Lisnichenko
On April 27, 2017, 6:09 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58801/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 6:09 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-20871
> https://issues.apache.org/jira/browse/AMBARI-20871
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have 2 different ways of creating repositories - one is creating a new file for each repo definition (standard installation) and one file containing multiple repo definitions (install_packages). These should both be done the same way (the install_packages way).
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 8c726a0f2d
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 74a2cf2e32
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/DistributeRepositoriesStructuredOutput.java 662b856c05
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 3681eda976
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d556b603a8
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java ab8b65968e
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java e39588ed42
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 811ce9b8cb
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java fdb7c8d9b8
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 33adce1414
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 6193c11c22
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py a35dce757e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 8f7b31ddea
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 4bed482f8d
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java c6ee87588c
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 77e3bee3f6
> ambari-server/src/test/python/custom_actions/configs/install_packages_repository_file.json PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/configs/repository_file.json PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 082d2001cf
>
>
> Diff: https://reviews.apache.org/r/58801/diff/1/
>
>
> Testing
> -------
>
> Manual for both centos6 and ubuntu14. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 58801: Unify repository file creation
Posted by Nate Cole <nc...@hortonworks.com>.
> On April 27, 2017, 2:59 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
> > Lines 38-44 (patched)
> > <https://reviews.apache.org/r/58801/diff/2/?file=1702048#file1702048line38>
> >
> > These are serialized to Python, right? As much as I love camelCase, do we need to use _ here?
Like 90% of the command json is camelCase, especially the top-level attributes. Within them (say, roleParams) the map keys have underscores. I wish we were consistent; in this case I took did what the majority of the file was formatted.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58801/#review173236
-----------------------------------------------------------
On April 27, 2017, 2:34 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58801/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 2:34 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-20871
> https://issues.apache.org/jira/browse/AMBARI-20871
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have 2 different ways of creating repositories - one is creating a new file for each repo definition (standard installation) and one file containing multiple repo definitions (install_packages). These should both be done the same way (the install_packages way).
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 8c726a0f2d
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 74a2cf2e32
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/DistributeRepositoriesStructuredOutput.java 662b856c05
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 3681eda976
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d556b603a8
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java ab8b65968e
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java e39588ed42
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 811ce9b8cb
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java fdb7c8d9b8
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 33adce1414
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 6193c11c22
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py a35dce757e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 8f7b31ddea
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 4bed482f8d
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java c6ee87588c
> ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java df69f68f6c
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java 3a5532b08d
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 77e3bee3f6
> ambari-server/src/test/python/custom_actions/configs/install_packages_repository_file.json PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/configs/repository_file.json PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 082d2001cf
>
>
> Diff: https://reviews.apache.org/r/58801/diff/2/
>
>
> Testing
> -------
>
> Manual for both centos6 and ubuntu14. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 58801: Unify repository file creation
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58801/#review173236
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
Lines 38-44 (patched)
<https://reviews.apache.org/r/58801/#comment246284>
These are serialized to Python, right? As much as I love camelCase, do we need to use _ here?
- Jonathan Hurley
On April 27, 2017, 2:34 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58801/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 2:34 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-20871
> https://issues.apache.org/jira/browse/AMBARI-20871
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have 2 different ways of creating repositories - one is creating a new file for each repo definition (standard installation) and one file containing multiple repo definitions (install_packages). These should both be done the same way (the install_packages way).
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 8c726a0f2d
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 74a2cf2e32
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/DistributeRepositoriesStructuredOutput.java 662b856c05
> ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 3681eda976
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d556b603a8
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java ab8b65968e
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java e39588ed42
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 811ce9b8cb
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java fdb7c8d9b8
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 33adce1414
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 6193c11c22
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py a35dce757e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 8f7b31ddea
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 4bed482f8d
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java c6ee87588c
> ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java df69f68f6c
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java 3a5532b08d
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 77e3bee3f6
> ambari-server/src/test/python/custom_actions/configs/install_packages_repository_file.json PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/configs/repository_file.json PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 082d2001cf
>
>
> Diff: https://reviews.apache.org/r/58801/diff/2/
>
>
> Testing
> -------
>
> Manual for both centos6 and ubuntu14. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 58801: Unify repository file creation
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58801/
-----------------------------------------------------------
(Updated April 27, 2017, 3:05 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Changes
-------
Updated test results.
Bugs: AMBARI-20871
https://issues.apache.org/jira/browse/AMBARI-20871
Repository: ambari
Description
-------
We have 2 different ways of creating repositories - one is creating a new file for each repo definition (standard installation) and one file containing multiple repo definitions (install_packages). These should both be done the same way (the install_packages way).
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 8c726a0f2d
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 74a2cf2e32
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/DistributeRepositoriesStructuredOutput.java 662b856c05
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 3681eda976
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d556b603a8
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java ab8b65968e
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java e39588ed42
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 811ce9b8cb
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java fdb7c8d9b8
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 33adce1414
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 6193c11c22
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py a35dce757e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 8f7b31ddea
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 4bed482f8d
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java c6ee87588c
ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java df69f68f6c
ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java 3a5532b08d
ambari-server/src/test/python/custom_actions/TestInstallPackages.py 77e3bee3f6
ambari-server/src/test/python/custom_actions/configs/install_packages_repository_file.json PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/configs/repository_file.json PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 082d2001cf
Diff: https://reviews.apache.org/r/58801/diff/2/
Testing (updated)
-------
Manual for both centos6 and ubuntu14. Automated pending.
Tests run: 5009, Failures: 0, Errors: 0, Skipped: 39
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:08 min
[INFO] Finished at: 2017-04-27T14:27:30-04:00
[INFO] Final Memory: 57M/635M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 58801: Unify repository file creation
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58801/
-----------------------------------------------------------
(Updated April 27, 2017, 2:34 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Changes
-------
Update for comments and test fixes.
Bugs: AMBARI-20871
https://issues.apache.org/jira/browse/AMBARI-20871
Repository: ambari
Description
-------
We have 2 different ways of creating repositories - one is creating a new file for each repo definition (standard installation) and one file containing multiple repo definitions (install_packages). These should both be done the same way (the install_packages way).
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 8c726a0f2d
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 74a2cf2e32
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/DistributeRepositoriesStructuredOutput.java 662b856c05
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 3681eda976
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d556b603a8
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java ab8b65968e
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java e39588ed42
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 811ce9b8cb
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java fdb7c8d9b8
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 33adce1414
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 6193c11c22
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py a35dce757e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 8f7b31ddea
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 4bed482f8d
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java c6ee87588c
ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java df69f68f6c
ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java 3a5532b08d
ambari-server/src/test/python/custom_actions/TestInstallPackages.py 77e3bee3f6
ambari-server/src/test/python/custom_actions/configs/install_packages_repository_file.json PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/configs/repository_file.json PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 082d2001cf
Diff: https://reviews.apache.org/r/58801/diff/2/
Changes: https://reviews.apache.org/r/58801/diff/1-2/
Testing
-------
Manual for both centos6 and ubuntu14. Automated pending.
Thanks,
Nate Cole