You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by fr...@apache.org on 2024/10/21 14:31:44 UTC

(logging-log4net) branch master updated: incorporated feedback from Stephen Webb to release review instructions

This is an automated email from the ASF dual-hosted git repository.

freeandnil pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4net.git


The following commit(s) were added to refs/heads/master by this push:
     new ffbe09e3 incorporated feedback from Stephen Webb to release review instructions
ffbe09e3 is described below

commit ffbe09e37af268249eab4fd0517fe8465b8b58b8
Author: Jan Friedrich <fr...@apache.org>
AuthorDate: Mon Oct 21 16:24:48 2024 +0200

    incorporated feedback from Stephen Webb to release review instructions
---
 src/log4net.sln                                       |  1 +
 src/site/xdoc/release/release-review-instructions.xml | 10 +++++++---
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/log4net.sln b/src/log4net.sln
index 69002f84..88013e13 100644
--- a/src/log4net.sln
+++ b/src/log4net.sln
@@ -47,6 +47,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".doc", ".doc", "{33D80AD3-8
 		..\doc\MailTemplate.Result.txt = ..\doc\MailTemplate.Result.txt
 		..\doc\MailTemplate.txt = ..\doc\MailTemplate.txt
 		site\xdoc\release\release-notes.xml = site\xdoc\release\release-notes.xml
+		site\xdoc\release\release-review-instructions.xml = site\xdoc\release\release-review-instructions.xml
 		..\doc\RELEASING.md = ..\doc\RELEASING.md
 	EndProjectSection
 EndProject
diff --git a/src/site/xdoc/release/release-review-instructions.xml b/src/site/xdoc/release/release-review-instructions.xml
index 8c93c1ec..e98532e0 100644
--- a/src/site/xdoc/release/release-review-instructions.xml
+++ b/src/site/xdoc/release/release-review-instructions.xml
@@ -32,15 +32,16 @@ limitations under the License.
             <li>
               Prerequisites (winget - in case of problems see next section choco)
               <pre class="code">winget install -e --id GnuPG.Gpg4win
-winget install -e --id TortoiseSVN.TortoiseSVN
+winget install -e --id TortoiseSVN.TortoiseSVN  # or any other subversion client
 winget install -e --id Mono.Mono
 winget install -e --id Microsoft.DotNet.SDK.8</pre>
+              <p>After installation, verify that gpg and svn are in the path and add them when not.</p>
             </li>
             <li>
               Prerequisites (choco - only in case of problems with winget)
               <pre class="code">Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; iex ((New-Object System.Net.WebClient).DownloadString('https://community.chocolatey.org/install.ps1'))
 choco install gpg4win
-choco install tortoisesvn
+choco install tortoisesvn  # or any other subversion client
 choco install mono
 choco install dotnet-8.0-sdk</pre>
             </li>
@@ -54,7 +55,10 @@ pushd log4net-{releaseVersion}</pre>
               <pre class="code">&amp; ./verify-release.ps1</pre>
             </li>
             <li>
-              <p>Verify the build</p>
+              switch to the directory where you extracted the sources (in case you didn't use verify-release.ps1)
+            </li>
+            <li>
+              Verify the build
               <pre class="code">dotnet test ./src/log4net.sln</pre>
             </li>
           </ol>