You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/03/21 18:46:34 UTC
Review Request 45114: GEODE-27: Adding spring-webmvc to pulse
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45114/
-----------------------------------------------------------
Review request for geode, Jason Huynh and Jens Deppe.
Repository: geode
Description
-------
Removing spring-webmvc from pulse caused these integration tests to fail:
com.gemstone.gemfire.distributed.LocatorLauncherAssemblyJUnitTest.testLocatorStopsWhenJmxPortIsZero
com.gemstone.gemfire.distributed.LocatorLauncherAssemblyJUnitTest.testLocatorStopsWhenJmxPortIsNonZero
com.gemstone.gemfire.management.internal.configuration.SharedConfigurationEndToEndDUnitTest.testStartServerAndExecuteCommands
Diffs
-----
geode-pulse/build.gradle 045d9038356a9bb2e543591211231e51456488fc
Diff: https://reviews.apache.org/r/45114/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 45114: GEODE-27: Adding spring-webmvc to pulse
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45114/#review124657
-----------------------------------------------------------
Ship it!
Ship It!
- Jason Huynh
On March 21, 2016, 5:46 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45114/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 5:46 p.m.)
>
>
> Review request for geode, Jason Huynh and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Removing spring-webmvc from pulse caused these integration tests to fail:
>
> com.gemstone.gemfire.distributed.LocatorLauncherAssemblyJUnitTest.testLocatorStopsWhenJmxPortIsZero
> com.gemstone.gemfire.distributed.LocatorLauncherAssemblyJUnitTest.testLocatorStopsWhenJmxPortIsNonZero
> com.gemstone.gemfire.management.internal.configuration.SharedConfigurationEndToEndDUnitTest.testStartServerAndExecuteCommands
>
>
> Diffs
> -----
>
> geode-pulse/build.gradle 045d9038356a9bb2e543591211231e51456488fc
>
> Diff: https://reviews.apache.org/r/45114/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 45114: GEODE-27: Adding spring-webmvc to pulse
Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45114/#review124662
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Bretl
On March 21, 2016, 10:46 a.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45114/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 10:46 a.m.)
>
>
> Review request for geode, Jason Huynh and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Removing spring-webmvc from pulse caused these integration tests to fail:
>
> com.gemstone.gemfire.distributed.LocatorLauncherAssemblyJUnitTest.testLocatorStopsWhenJmxPortIsZero
> com.gemstone.gemfire.distributed.LocatorLauncherAssemblyJUnitTest.testLocatorStopsWhenJmxPortIsNonZero
> com.gemstone.gemfire.management.internal.configuration.SharedConfigurationEndToEndDUnitTest.testStartServerAndExecuteCommands
>
>
> Diffs
> -----
>
> geode-pulse/build.gradle 045d9038356a9bb2e543591211231e51456488fc
>
> Diff: https://reviews.apache.org/r/45114/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 45114: GEODE-27: Adding spring-webmvc to pulse
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45114/#review124676
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On March 21, 2016, 5:46 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45114/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 5:46 p.m.)
>
>
> Review request for geode, Jason Huynh and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Removing spring-webmvc from pulse caused these integration tests to fail:
>
> com.gemstone.gemfire.distributed.LocatorLauncherAssemblyJUnitTest.testLocatorStopsWhenJmxPortIsZero
> com.gemstone.gemfire.distributed.LocatorLauncherAssemblyJUnitTest.testLocatorStopsWhenJmxPortIsNonZero
> com.gemstone.gemfire.management.internal.configuration.SharedConfigurationEndToEndDUnitTest.testStartServerAndExecuteCommands
>
>
> Diffs
> -----
>
> geode-pulse/build.gradle 045d9038356a9bb2e543591211231e51456488fc
>
> Diff: https://reviews.apache.org/r/45114/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>