[GitHub] [arrow] icexelloss commented on a diff in pull request #34392: GH-34391: [C++] Future as-of-join-node hangs on distant times

["icexelloss (via GitHub)" <gi...@apache.org>]

icexelloss commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1213568918


##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -1059,7 +1232,7 @@ class AsofJoinNode : public ExecNode {
         // If RHS is finished, then we know it's up to date
         if (rhs.CurrentEmpty())
           return false;  // RHS isn't finished, but is empty --> not up to date
-        if (lhs_ts >= rhs.GetCurrentTime())

Review Comment:
   > Docstring says "Returns false if RHS not up to date for LHS". This implies that only strict inequality should return false, no?
   
   I am not sure if that is correct and am hoping for more detailed reason than "IIRC, this fix was needed after the MemoStore changes for a future as-of-join."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org