You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Volker Mische (Created) (JIRA)" <ji...@apache.org> on 2011/12/07 14:48:40 UTC
[jira] [Created] (COUCHDB-1358) Only delete files with .view
extension
Only delete files with .view extension
--------------------------------------
Key: COUCHDB-1358
URL: https://issues.apache.org/jira/browse/COUCHDB-1358
Project: CouchDB
Issue Type: Improvement
Components: Database Core
Affects Versions: 1.1.1
Reporter: Volker Mische
Priority: Minor
Fix For: 1.1.2
Attachments: cleanup-views-only.patch
Currently all files in the view directory that are not used by any View group are deleted by the _view_cleanup endpoint. If other indexers (like GeoCouch) store indexes in the same directory, they get deleted as well.
The attached patch changes the bahaviour and only deletes files ending with ".view". Leftovers from compaction are deletes as well as they end with ".compact.view".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (COUCHDB-1358) Only delete files with .view
extension
Posted by "Paul Joseph Davis (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Joseph Davis closed COUCHDB-1358.
--------------------------------------
Resolution: Fixed
Applied to 1.2.x and 1.1.x
> Only delete files with .view extension
> --------------------------------------
>
> Key: COUCHDB-1358
> URL: https://issues.apache.org/jira/browse/COUCHDB-1358
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.1.1
> Reporter: Volker Mische
> Priority: Minor
> Fix For: 1.1.2
>
> Attachments: cleanup-views-only.patch
>
>
> Currently all files in the view directory that are not used by any View group are deleted by the _view_cleanup endpoint. If other indexers (like GeoCouch) store indexes in the same directory, they get deleted as well.
> The attached patch changes the bahaviour and only deletes files ending with ".view". Leftovers from compaction are deletes as well as they end with ".compact.view".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1358) Only delete files with .view
extension
Posted by "Adam Kocoloski (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165289#comment-13165289 ]
Adam Kocoloski commented on COUCHDB-1358:
-----------------------------------------
Seems harmless to me. Let's add it.
> Only delete files with .view extension
> --------------------------------------
>
> Key: COUCHDB-1358
> URL: https://issues.apache.org/jira/browse/COUCHDB-1358
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.1.1
> Reporter: Volker Mische
> Priority: Minor
> Fix For: 1.1.2
>
> Attachments: cleanup-views-only.patch
>
>
> Currently all files in the view directory that are not used by any View group are deleted by the _view_cleanup endpoint. If other indexers (like GeoCouch) store indexes in the same directory, they get deleted as well.
> The attached patch changes the bahaviour and only deletes files ending with ".view". Leftovers from compaction are deletes as well as they end with ".compact.view".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COUCHDB-1358) Only delete files with .view
extension
Posted by "Volker Mische (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Volker Mische updated COUCHDB-1358:
-----------------------------------
Attachment: cleanup-views-only.patch
Only delete files ending with ".view".
> Only delete files with .view extension
> --------------------------------------
>
> Key: COUCHDB-1358
> URL: https://issues.apache.org/jira/browse/COUCHDB-1358
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.1.1
> Reporter: Volker Mische
> Priority: Minor
> Fix For: 1.1.2
>
> Attachments: cleanup-views-only.patch
>
>
> Currently all files in the view directory that are not used by any View group are deleted by the _view_cleanup endpoint. If other indexers (like GeoCouch) store indexes in the same directory, they get deleted as well.
> The attached patch changes the bahaviour and only deletes files ending with ".view". Leftovers from compaction are deletes as well as they end with ".compact.view".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1358) Only delete files with .view
extension
Posted by "Jason Smith (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165727#comment-13165727 ]
Jason Smith commented on COUCHDB-1358:
--------------------------------------
Paul makes a good point. However, it also seems reasonable that an indexer creates ".foo" files when it runs, and deletes ".foo" files when it cleans. Perhaps a site backup script is running, or rsync or something, placing siblings alongside the .view files. Cleanup shouldn't remove them either.
> Only delete files with .view extension
> --------------------------------------
>
> Key: COUCHDB-1358
> URL: https://issues.apache.org/jira/browse/COUCHDB-1358
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.1.1
> Reporter: Volker Mische
> Priority: Minor
> Fix For: 1.1.2
>
> Attachments: cleanup-views-only.patch
>
>
> Currently all files in the view directory that are not used by any View group are deleted by the _view_cleanup endpoint. If other indexers (like GeoCouch) store indexes in the same directory, they get deleted as well.
> The attached patch changes the bahaviour and only deletes files ending with ".view". Leftovers from compaction are deletes as well as they end with ".compact.view".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1358) Only delete files with .view
extension
Posted by "Paul Joseph Davis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164630#comment-13164630 ]
Paul Joseph Davis commented on COUCHDB-1358:
--------------------------------------------
I haven't thought about it too hard, but I've been running under the assumption that indexers would just store their files in their own directories and be responsible for their own cleanup. Is there a good reason to munge these things together?
> Only delete files with .view extension
> --------------------------------------
>
> Key: COUCHDB-1358
> URL: https://issues.apache.org/jira/browse/COUCHDB-1358
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.1.1
> Reporter: Volker Mische
> Priority: Minor
> Fix For: 1.1.2
>
> Attachments: cleanup-views-only.patch
>
>
> Currently all files in the view directory that are not used by any View group are deleted by the _view_cleanup endpoint. If other indexers (like GeoCouch) store indexes in the same directory, they get deleted as well.
> The attached patch changes the bahaviour and only deletes files ending with ".view". Leftovers from compaction are deletes as well as they end with ".compact.view".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1358) Only delete files with .view
extension
Posted by "Volker Mische (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165138#comment-13165138 ]
Volker Mische commented on COUCHDB-1358:
----------------------------------------
The reason was simplicity. No new conf variable etc.
With the indexer refactor (which is is trunk) it's not an issue anymore.
I can fully understand if there's no good reason for CouchDB to apply this patch. But it made sense to have it tracked somewhere at least.
> Only delete files with .view extension
> --------------------------------------
>
> Key: COUCHDB-1358
> URL: https://issues.apache.org/jira/browse/COUCHDB-1358
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.1.1
> Reporter: Volker Mische
> Priority: Minor
> Fix For: 1.1.2
>
> Attachments: cleanup-views-only.patch
>
>
> Currently all files in the view directory that are not used by any View group are deleted by the _view_cleanup endpoint. If other indexers (like GeoCouch) store indexes in the same directory, they get deleted as well.
> The attached patch changes the bahaviour and only deletes files ending with ".view". Leftovers from compaction are deletes as well as they end with ".compact.view".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1358) Only delete files with .view
extension
Posted by "Paul Joseph Davis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165234#comment-13165234 ]
Paul Joseph Davis commented on COUCHDB-1358:
--------------------------------------------
I'm not super against it by any means and was mostly thinking of the new indexers. If no one else objects I'll commit this.
> Only delete files with .view extension
> --------------------------------------
>
> Key: COUCHDB-1358
> URL: https://issues.apache.org/jira/browse/COUCHDB-1358
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.1.1
> Reporter: Volker Mische
> Priority: Minor
> Fix For: 1.1.2
>
> Attachments: cleanup-views-only.patch
>
>
> Currently all files in the view directory that are not used by any View group are deleted by the _view_cleanup endpoint. If other indexers (like GeoCouch) store indexes in the same directory, they get deleted as well.
> The attached patch changes the bahaviour and only deletes files ending with ".view". Leftovers from compaction are deletes as well as they end with ".compact.view".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira