You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/10/19 16:24:35 UTC

Re: Review Request 62911: Added a ReadWriteLock to libprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62911/
-----------------------------------------------------------

(Updated Oct. 19, 2017, 4:24 p.m.)


Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and Jason Lai.


Changes
-------

Review comments from @bmahler.


Summary (updated)
-----------------

Added a ReadWriteLock to libprocess.


Bugs: MESOS-8075
    https://issues.apache.org/jira/browse/MESOS-8075


Repository: mesos


Description (updated)
-------

The `ReadWriteLock` class is similar to `Mutex`, but allows extra concurrency if
some actions can be performed concurrently safely while certain actions
require full mutual exclusive.

This implementation guarantees starvation free for `write_lock()` by queuing up
`read_lock()` when some `write_lock()` is already in queue.


Diffs (updated)
-----

  3rdparty/libprocess/include/Makefile.am 94c7a722aab6c36174f117f0b6239cb988e476a9 
  3rdparty/libprocess/include/process/rwlock.hpp PRE-CREATION 


Diff: https://reviews.apache.org/r/62911/diff/4/

Changes: https://reviews.apache.org/r/62911/diff/3-4/


Testing
-------


Thanks,

Zhitao Li

Re: Review Request 62911: Added a ReadWriteLock to libprocess.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62911/#review188779
-----------------------------------------------------------




3rdparty/libprocess/include/process/rwlock.hpp
Lines 155 (patched)
<https://reviews.apache.org/r/62911/#comment265796>

    one more space?


- Gilbert Song


On Oct. 19, 2017, 9:24 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62911/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 9:24 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and Jason Lai.
> 
> 
> Bugs: MESOS-8075
>     https://issues.apache.org/jira/browse/MESOS-8075
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `ReadWriteLock` class is similar to `Mutex`, but allows extra concurrency if
> some actions can be performed concurrently safely while certain actions
> require full mutual exclusive.
> 
> This implementation guarantees starvation free for `write_lock()` by queuing up
> `read_lock()` when some `write_lock()` is already in queue.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/Makefile.am 94c7a722aab6c36174f117f0b6239cb988e476a9 
>   3rdparty/libprocess/include/process/rwlock.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62911/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 62911: Added a ReadWriteLock to libprocess.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62911/#review188771
-----------------------------------------------------------


Ship it!




Made some minor tweaks to the comments and added some TODOs, looks good!

- Benjamin Mahler


On Oct. 19, 2017, 4:24 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62911/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 4:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and Jason Lai.
> 
> 
> Bugs: MESOS-8075
>     https://issues.apache.org/jira/browse/MESOS-8075
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `ReadWriteLock` class is similar to `Mutex`, but allows extra concurrency if
> some actions can be performed concurrently safely while certain actions
> require full mutual exclusive.
> 
> This implementation guarantees starvation free for `write_lock()` by queuing up
> `read_lock()` when some `write_lock()` is already in queue.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/Makefile.am 94c7a722aab6c36174f117f0b6239cb988e476a9 
>   3rdparty/libprocess/include/process/rwlock.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62911/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>