You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "shameersss1 (via GitHub)" <gi...@apache.org> on 2025/02/15 08:36:54 UTC
[PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
shameersss1 opened a new pull request, #26162:
URL: https://github.com/apache/flink/pull/26162
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Currently when "table.optimizer.source.report-statistics-enabled" is set to false, The statistics collection is not disabled for all the cases. It was noted that when running Batch workload to read Hive table TPC-DS data set, although "table.optimizer.source.report-statistics-enabled" was set to false, both table and column statistics were being collected.
## Brief change log
Skipping stats computation in `FlinkRecomputeStatisticsProgram.java` when "table.optimizer.source.report-statistics-enabled" is false
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #26162: [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False
URL: https://github.com/apache/flink/pull/26162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-4278535603
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "shameersss1 (via GitHub)" <gi...@apache.org>.
shameersss1 commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2710471947
> `getPartitionsTableStats`
Thanks a lot @xuyangzhong for the review
1. Yes, you are correct, it never stated it skips stats collection from catalog.
2. Fetching stats from catalog may be a good option for all the cases, in some cases it is better to just turn it off.
3. inorder to do the same, i propose, let;s reuse the same config and skip stats alltogether both for source and catalog or introduce a different config to do the same.
@xuyangzhong Any thoughts on the above ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "shameersss1 (via GitHub)" <gi...@apache.org>.
shameersss1 commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2687817760
@dawidwys @twalthr @xuyangzhong - Gentle reminder for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "xuyangzhong (via GitHub)" <gi...@apache.org>.
xuyangzhong commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2712270418
@shameersss1 Whether we modify the scope of the current configuration or introduce a new one, it's advisable to implement changes through a Flip, as these configurations are part of the public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "JunRuiLee (via GitHub)" <gi...@apache.org>.
JunRuiLee commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2677503326
> @twalthr @JunRuiLee Could you please review the changes ?
Sorry @shameersss1 I am not very familiar with this part of the logic, maybe @xuyangzhong can provide some suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2954778779
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "shameersss1 (via GitHub)" <gi...@apache.org>.
shameersss1 commented on code in PR #26162:
URL: https://github.com/apache/flink/pull/26162#discussion_r1963492616
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRecomputeStatisticsProgram.java:
##########
@@ -115,25 +115,26 @@ private TableStats recomputeStatistics(
FilterPushDownSpec filterPushDownSpec,
boolean reportStatEnabled) {
TableStats origTableStats = table.getStatistic().getTableStats();
+ // bail out early if stats computation is disabled.
+ if (!reportStatEnabled) {
+ return origTableStats;
+ }
DynamicTableSource tableSource = table.tableSource();
if (filterPushDownSpec != null && !filterPushDownSpec.isAllPredicatesRetained()) {
// filter push down but some predicates are accepted by source and not in reaming
// predicates
// the catalog do not support get statistics with filters,
- // so only call reportStatistics method if reportStatEnabled is true
+ // so only call reportStatistics
Review Comment:
Ack. Will reword it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "shameersss1 (via GitHub)" <gi...@apache.org>.
shameersss1 commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2677406141
@twalthr @JunRuiLee Could you please review the changes ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "shameersss1 (via GitHub)" <gi...@apache.org>.
shameersss1 commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2673427565
@davidradl - I have addressed your comments. Could you please review the same ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "shameersss1 (via GitHub)" <gi...@apache.org>.
shameersss1 commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2709581017
Thanks @davidradl for the review.
@JunRuiLee - Could you please point to anyone else who knows this flow and can do the review ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "xuyangzhong (via GitHub)" <gi...@apache.org>.
xuyangzhong commented on code in PR #26162:
URL: https://github.com/apache/flink/pull/26162#discussion_r1987137226
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRecomputeStatisticsProgram.java:
##########
@@ -115,25 +115,26 @@ private TableStats recomputeStatistics(
FilterPushDownSpec filterPushDownSpec,
boolean reportStatEnabled) {
TableStats origTableStats = table.getStatistic().getTableStats();
+ // bail out early if stats computation is disabled.
+ if (!reportStatEnabled) {
+ return origTableStats;
+ }
DynamicTableSource tableSource = table.tableSource();
if (filterPushDownSpec != null && !filterPushDownSpec.isAllPredicatesRetained()) {
// filter push down but some predicates are accepted by source and not in reaming
// predicates
// the catalog do not support get statistics with filters,
- // so only call reportStatistics method if reportStatEnabled is true
+ // so call reportStatistics method of the table source.
// TODO estimate statistics by selectivity
- return reportStatEnabled
- ? ((SupportsStatisticReport) tableSource).reportStatistics()
- : null;
Review Comment:
I believe we should retain the logic that returns null, as our initial commit indicated the intention to remove table statistics after filter pushdown, rather than using the existing table statistics. See more here #Line 182
https://github.com/apache/flink/pull/12866/files#diff-cf75b056be8a3cf477444a51584fe44a08e0c5e8b8c553c8f4f07a202830edf1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2660821630
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b79dd61d83e7894d806901120a66067486db35b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b79dd61d83e7894d806901120a66067486db35b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b79dd61d83e7894d806901120a66067486db35b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "shameersss1 (via GitHub)" <gi...@apache.org>.
shameersss1 commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2671472525
> Please could you add a unit test.
Sure will add a UT for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26162:
URL: https://github.com/apache/flink/pull/26162#discussion_r1963420772
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRecomputeStatisticsProgram.java:
##########
@@ -115,25 +115,26 @@ private TableStats recomputeStatistics(
FilterPushDownSpec filterPushDownSpec,
boolean reportStatEnabled) {
TableStats origTableStats = table.getStatistic().getTableStats();
+ // bail out early if stats computation is disabled.
+ if (!reportStatEnabled) {
+ return origTableStats;
+ }
DynamicTableSource tableSource = table.tableSource();
if (filterPushDownSpec != null && !filterPushDownSpec.isAllPredicatesRetained()) {
// filter push down but some predicates are accepted by source and not in reaming
// predicates
// the catalog do not support get statistics with filters,
- // so only call reportStatistics method if reportStatEnabled is true
+ // so only call reportStatistics
Review Comment:
nit: the comment now does not read well. "so only call reportStatistics" implies there will be more to the sentence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "shameersss1 (via GitHub)" <gi...@apache.org>.
shameersss1 commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2660820214
@JunRuiLee Could you please review the changes ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "shameersss1 (via GitHub)" <gi...@apache.org>.
shameersss1 commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2662159840
@reswqa @JunRuiLee @dawidwys Could you please review the changes ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "shameersss1 (via GitHub)" <gi...@apache.org>.
shameersss1 commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2677518220
Thanks @JunRuiLee for the pointers.
@davidradl @xuyangzhong Could you please review the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-4495731158
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org