You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Frédéric THOMAS <we...@hotmail.com> on 2015/07/01 18:46:53 UTC
RE: [3/5] git commit: [flex-falcon] [refs/heads/develop] - Fix NPE
Correct, I haven't planed for the build out of IntelliJ , we are likely to find more of them.
eg. IntelliJ passes a config.xml and in more prevent you have a build configuration without output path.
Frédéric THOMAS
----------------------------------------
> From: erikdebruin@apache.org
> To: commits@flex.apache.org
> Date: Wed, 1 Jul 2015 15:46:36 +0000
> Subject: [3/5] git commit: [flex-falcon] [refs/heads/develop] - Fix NPE
>
> Fix NPE
>
> This time such that the diff looks nicer ;-)
>
> Signed-off-by: Erik de Bruin <er...@ixsoftware.nl>
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/099263d4
> Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/099263d4
> Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/099263d4
>
> Branch: refs/heads/develop
> Commit: 099263d45f8fbdc7f332e801704f14129ea9bdbb
> Parents: 185c377
> Author: Erik de Bruin <er...@ixsoftware.nl>
> Authored: Wed Jul 1 17:36:23 2015 +0200
> Committer: Erik de Bruin <er...@ixsoftware.nl>
> Committed: Wed Jul 1 17:36:23 2015 +0200
>
> ----------------------------------------------------------------------
> flex-compiler-oem/src/flex2/tools/Tool.java | 4 ++++
> 1 file changed, 4 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/099263d4/flex-compiler-oem/src/flex2/tools/Tool.java
> ----------------------------------------------------------------------
> diff --git a/flex-compiler-oem/src/flex2/tools/Tool.java b/flex-compiler-oem/src/flex2/tools/Tool.java
> index 132ea31..1e4c516 100644
> --- a/flex-compiler-oem/src/flex2/tools/Tool.java
> +++ b/flex-compiler-oem/src/flex2/tools/Tool.java
> @@ -190,6 +190,10 @@ public class Tool
> throws org.apache.flex.compiler.exceptions.ConfigurationException
> {
> final String configFilePath = ArgumentUtil.getValue(args, "-load-config");
> + if (configFilePath == null)
> + {
> + return null;
> + }
> final File configFile = new File(configFilePath);
> final FileSpecification fileSpecification = new FileSpecification(configFile.getAbsolutePath());
> final ConfigurationBuffer cfgbuf = createConfigurationBuffer(Configuration.class);
>
RE: [3/5] git commit: [flex-falcon] [refs/heads/develop] - Fix NPE
Posted by Frédéric THOMAS <we...@hotmail.com>.
Well, I'm for anything that can improve what I did and for sure, the command line wasn't included, so, go ahead, I like :-)
Frédéric THOMAS
----------------------------------------
> From: erik@ixsoftware.nl
> Date: Wed, 1 Jul 2015 18:51:58 +0200
> Subject: Re: [3/5] git commit: [flex-falcon] [refs/heads/develop] - Fix NPE
> To: dev@flex.apache.org
>
>>
>> eg. IntelliJ passes a config.xml and in more prevent you have a build
>> configuration without output path.
>>
>
> Yeah, but having an '-output' argument will force the 'js/out' parent
> directories to be created, something I thought wasn't very helpful if
> you're building from the command line. Why nest any deeper than is already
> necessary?
>
> EdB
>
>
>
>
>> Frédéric THOMAS
>>
>>
>> ----------------------------------------
>>> From: erikdebruin@apache.org
>>> To: commits@flex.apache.org
>>> Date: Wed, 1 Jul 2015 15:46:36 +0000
>>> Subject: [3/5] git commit: [flex-falcon] [refs/heads/develop] - Fix NPE
>>>
>>> Fix NPE
>>>
>>> This time such that the diff looks nicer ;-)
>>>
>>> Signed-off-by: Erik de Bruin <er...@ixsoftware.nl>
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
>>> Commit:
>> http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/099263d4
>>> Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/099263d4
>>> Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/099263d4
>>>
>>> Branch: refs/heads/develop
>>> Commit: 099263d45f8fbdc7f332e801704f14129ea9bdbb
>>> Parents: 185c377
>>> Author: Erik de Bruin <er...@ixsoftware.nl>
>>> Authored: Wed Jul 1 17:36:23 2015 +0200
>>> Committer: Erik de Bruin <er...@ixsoftware.nl>
>>> Committed: Wed Jul 1 17:36:23 2015 +0200
>>>
>>> ----------------------------------------------------------------------
>>> flex-compiler-oem/src/flex2/tools/Tool.java | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>> ----------------------------------------------------------------------
>>>
>>>
>>>
>> http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/099263d4/flex-compiler-oem/src/flex2/tools/Tool.java
>>> ----------------------------------------------------------------------
>>> diff --git a/flex-compiler-oem/src/flex2/tools/Tool.java
>> b/flex-compiler-oem/src/flex2/tools/Tool.java
>>> index 132ea31..1e4c516 100644
>>> --- a/flex-compiler-oem/src/flex2/tools/Tool.java
>>> +++ b/flex-compiler-oem/src/flex2/tools/Tool.java
>>> @@ -190,6 +190,10 @@ public class Tool
>>> throws org.apache.flex.compiler.exceptions.ConfigurationException
>>> {
>>> final String configFilePath = ArgumentUtil.getValue(args,
>> "-load-config");
>>> + if (configFilePath == null)
>>> + {
>>> + return null;
>>> + }
>>> final File configFile = new File(configFilePath);
>>> final FileSpecification fileSpecification = new
>> FileSpecification(configFile.getAbsolutePath());
>>> final ConfigurationBuffer cfgbuf =
>> createConfigurationBuffer(Configuration.class);
>>>
>>
>>
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
Re: [3/5] git commit: [flex-falcon] [refs/heads/develop] - Fix NPE
Posted by Erik de Bruin <er...@ixsoftware.nl>.
>
> eg. IntelliJ passes a config.xml and in more prevent you have a build
> configuration without output path.
>
Yeah, but having an '-output' argument will force the 'js/out' parent
directories to be created, something I thought wasn't very helpful if
you're building from the command line. Why nest any deeper than is already
necessary?
EdB
> Frédéric THOMAS
>
>
> ----------------------------------------
> > From: erikdebruin@apache.org
> > To: commits@flex.apache.org
> > Date: Wed, 1 Jul 2015 15:46:36 +0000
> > Subject: [3/5] git commit: [flex-falcon] [refs/heads/develop] - Fix NPE
> >
> > Fix NPE
> >
> > This time such that the diff looks nicer ;-)
> >
> > Signed-off-by: Erik de Bruin <er...@ixsoftware.nl>
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
> > Commit:
> http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/099263d4
> > Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/099263d4
> > Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/099263d4
> >
> > Branch: refs/heads/develop
> > Commit: 099263d45f8fbdc7f332e801704f14129ea9bdbb
> > Parents: 185c377
> > Author: Erik de Bruin <er...@ixsoftware.nl>
> > Authored: Wed Jul 1 17:36:23 2015 +0200
> > Committer: Erik de Bruin <er...@ixsoftware.nl>
> > Committed: Wed Jul 1 17:36:23 2015 +0200
> >
> > ----------------------------------------------------------------------
> > flex-compiler-oem/src/flex2/tools/Tool.java | 4 ++++
> > 1 file changed, 4 insertions(+)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/099263d4/flex-compiler-oem/src/flex2/tools/Tool.java
> > ----------------------------------------------------------------------
> > diff --git a/flex-compiler-oem/src/flex2/tools/Tool.java
> b/flex-compiler-oem/src/flex2/tools/Tool.java
> > index 132ea31..1e4c516 100644
> > --- a/flex-compiler-oem/src/flex2/tools/Tool.java
> > +++ b/flex-compiler-oem/src/flex2/tools/Tool.java
> > @@ -190,6 +190,10 @@ public class Tool
> > throws org.apache.flex.compiler.exceptions.ConfigurationException
> > {
> > final String configFilePath = ArgumentUtil.getValue(args,
> "-load-config");
> > + if (configFilePath == null)
> > + {
> > + return null;
> > + }
> > final File configFile = new File(configFilePath);
> > final FileSpecification fileSpecification = new
> FileSpecification(configFile.getAbsolutePath());
> > final ConfigurationBuffer cfgbuf =
> createConfigurationBuffer(Configuration.class);
> >
>
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl