You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/07/13 18:59:42 UTC

[GitHub] [trafficserver] gtenev commented on a change in pull request #6880: Add new API / TSPluginDSOReloadEnable to override DSO remap dynamic reload.

gtenev commented on a change in pull request #6880:
URL: https://github.com/apache/trafficserver/pull/6880#discussion_r453863065



##########
File path: proxy/http/remap/unit-tests/test_PluginFactory.cc
##########
@@ -778,6 +830,51 @@ SCENARIO("loading multiple version of the same plugin at the same time", "[plugi
     }
   }
 
+  GIVEN("two different versions v1 and v2 of same plugin with different time stamps - dynamic plugin reload ENABLED")
+  {
+    WHEN("(1) loading v1, (2) overwriting with v2 and then (3) reloading by using the same plugin name, "
+         "(*) v1 and v2 DSOs modification time are different (changed)")
+    {
+      // disablePluginDynamicReload();

Review comment:
       is this copy-paste/testing remnant ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org