You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by yisong-yue <gi...@git.apache.org> on 2018/09/29 07:32:48 UTC
[GitHub] zookeeper pull request #649: ZOOKEEPER-2847: Cannot bind to client port when...
GitHub user yisong-yue opened a pull request:
https://github.com/apache/zookeeper/pull/649
ZOOKEEPER-2847: Cannot bind to client port when reconfig based on old static config
PR No.2: Prevent removing client info from static config file to fix ReconfigLegacyTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yisong-yue/zookeeper ZOOKEEPER-2847
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/649.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #649
----
commit 5a9173b681c4bc4d508cceaafff53d5407027721
Author: Yisong Yue <yi...@...>
Date: 2018-09-29T07:18:32Z
ZOOKEEPER-2847: Cannot bind to client port when reconfig based on old static config
----
---
[GitHub] zookeeper issue #649: ZOOKEEPER-2847: Cannot bind to client port when reconf...
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/649
retest this please
---
[GitHub] zookeeper issue #649: ZOOKEEPER-2847: Cannot bind to client port when reconf...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/649
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2295/
---
[GitHub] zookeeper pull request #649: ZOOKEEPER-2847: Cannot bind to client port when...
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/649#discussion_r221472398
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
@@ -306,7 +308,7 @@ public String toString(){
}
if (type == LearnerType.OBSERVER) sw.append(":observer");
else if (type == LearnerType.PARTICIPANT) sw.append(":participant");
- if (clientAddr!=null){
+ if (clientAddr!=null && !isClientAddrFromStatic){
--- End diff --
Not sure we should do this or not, others LGTM.
---
[GitHub] zookeeper pull request #649: ZOOKEEPER-2847: Cannot bind to client port when...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/649#discussion_r221492399
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
@@ -306,7 +308,7 @@ public String toString(){
}
if (type == LearnerType.OBSERVER) sw.append(":observer");
else if (type == LearnerType.PARTICIPANT) sw.append(":participant");
- if (clientAddr!=null){
+ if (clientAddr!=null && !isClientAddrFromStatic){
--- End diff --
seems good to keep the old semantic, there are some test cases that might check this. Though it should be ok to not to this too as toString is not on critical path of any functionality as far as I know.
---
[GitHub] zookeeper issue #649: ZOOKEEPER-2847: Cannot bind to client port when reconf...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/649
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2286/
---
[GitHub] zookeeper pull request #649: ZOOKEEPER-2847: Cannot bind to client port when...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/649
---