You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/08/07 03:29:37 UTC

[kudu-CR] [raft c]

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17762


Change subject: [raft_c]
......................................................................

[raft_c]

In one of pre-commit builds by gerrit, the TestNewLeaderCantResolvePeers
scenario of the RaftConsensusElectionITest test suite failed.  I took
a closer look and found that running the scenario was failing in about
6% of all runs for RELEASE builds.

This patch addresses the flakiness:
  before 14 out of 256 failed when running with --stress_cpu_threads=16:
    http://dist-test.cloudera.org/job?job_id=aserbin.1628274899.91786

  after  0  out of 256 failed when running with --stress_cpu_threads=16:
    http://dist-test.cloudera.org/job?job_id=aserbin.1628306137.118392

Change-Id: I72819f710abb9931af73c22dbc2e0cb2fb7dd735
---
M src/kudu/integration-tests/raft_consensus_election-itest.cc
1 file changed, 37 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/17762/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I72819f710abb9931af73c22dbc2e0cb2fb7dd735
Gerrit-Change-Number: 17762
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [raft consensus election-itest] fix flakiness in one scenario

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17762 )

Change subject: [raft_consensus_election-itest] fix flakiness in one scenario
......................................................................

[raft_consensus_election-itest] fix flakiness in one scenario

In one of pre-commit builds by gerrit, the TestNewLeaderCantResolvePeers
scenario of the RaftConsensusElectionITest test suite failed.  I took
a closer look and found that running the scenario was failing in about
6% of all runs for RELEASE builds.

This patch addresses the flakiness:
  before 14 out of 256 failed when running with --stress_cpu_threads=16:
    http://dist-test.cloudera.org/job?job_id=aserbin.1628274899.91786

  after  0  out of 256 failed when running with --stress_cpu_threads=16:
    http://dist-test.cloudera.org/job?job_id=aserbin.1628306137.118392

Change-Id: I72819f710abb9931af73c22dbc2e0cb2fb7dd735
Reviewed-on: http://gerrit.cloudera.org:8080/17762
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/integration-tests/raft_consensus_election-itest.cc
1 file changed, 37 insertions(+), 16 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I72819f710abb9931af73c22dbc2e0cb2fb7dd735
Gerrit-Change-Number: 17762
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [raft consensus election-itest] fix flakiness in one scenario

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17762 )

Change subject: [raft_consensus_election-itest] fix flakiness in one scenario
......................................................................


Patch Set 3: Code-Review+2

Thanks for the flaky robustness improvements here!


-- 
To view, visit http://gerrit.cloudera.org:8080/17762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72819f710abb9931af73c22dbc2e0cb2fb7dd735
Gerrit-Change-Number: 17762
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 07 Aug 2021 04:36:36 +0000
Gerrit-HasComments: No

[kudu-CR] [raft consensus election-itest] fix flakiness in one scenario

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17762

to look at the new patch set (#2).

Change subject: [raft_consensus_election-itest] fix flakiness in one scenario
......................................................................

[raft_consensus_election-itest] fix flakiness in one scenario

In one of pre-commit builds by gerrit, the TestNewLeaderCantResolvePeers
scenario of the RaftConsensusElectionITest test suite failed.  I took
a closer look and found that running the scenario was failing in about
6% of all runs for RELEASE builds.

This patch addresses the flakiness:
  before 14 out of 256 failed when running with --stress_cpu_threads=16:
    http://dist-test.cloudera.org/job?job_id=aserbin.1628274899.91786

  after  0  out of 256 failed when running with --stress_cpu_threads=16:
    http://dist-test.cloudera.org/job?job_id=aserbin.1628306137.118392

Change-Id: I72819f710abb9931af73c22dbc2e0cb2fb7dd735
---
M src/kudu/integration-tests/raft_consensus_election-itest.cc
1 file changed, 37 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/17762/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I72819f710abb9931af73c22dbc2e0cb2fb7dd735
Gerrit-Change-Number: 17762
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)