You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/12 19:41:56 UTC
[GitHub] [flink] jianyun8023 opened a new pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
jianyun8023 opened a new pull request #14623:
URL: https://github.com/apache/flink/pull/14623
## What is the purpose of the change
Add the `SinkFunction` implementation of Pulsar to the connector.
## Brief change log
- Add Pulsar `SinkFunction` implementation
- Supports exactly-one base pulsar Transaction
- Add Pulsar's native type, based on `FormatFactory`
## Verifying this change
This change added tests and can be verified as follows:
- Pulsar sink's basic test
- Exactly-once for sink
- Pulsar's native type unit test
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (**yes** / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / **don't know**)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / **docs** / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-771497779
Sorry for coming back so late to this PR. Code-wise, it looks mostly fine. I would add a complete code review later.
However, I'd like to clarify first, why we want to have the old implementation in Flink master at all. From my perspective, this is instant legacy. So there needs to be a strong reason to have it compared to merge only the new interfaces.
Possible reasons could include features that cannot be supported with the new PulsarSink. In general, when would a user choose the old implementation over the new implementation given that the new sink interface is quite stable in Flink 1.13?
I'm duplicating the reply to the Source PR as the answer may be different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-758904858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f28be8f0598d98586165e832081f030e185d5b6a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944",
"triggerID" : "f28be8f0598d98586165e832081f030e185d5b6a",
"triggerType" : "PUSH"
}, {
"hash" : "e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12072",
"triggerID" : "e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f28be8f0598d98586165e832081f030e185d5b6a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944)
* e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12072)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-758904858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f28be8f0598d98586165e832081f030e185d5b6a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944",
"triggerID" : "f28be8f0598d98586165e832081f030e185d5b6a",
"triggerType" : "PUSH"
}, {
"hash" : "e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12072",
"triggerID" : "e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5",
"triggerType" : "PUSH"
}, {
"hash" : "8424254a9dee042e3ec96d21f7541dc25ee9bd6c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8424254a9dee042e3ec96d21f7541dc25ee9bd6c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f28be8f0598d98586165e832081f030e185d5b6a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944)
* e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12072)
* 8424254a9dee042e3ec96d21f7541dc25ee9bd6c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-758904858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f28be8f0598d98586165e832081f030e185d5b6a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f28be8f0598d98586165e832081f030e185d5b6a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f28be8f0598d98586165e832081f030e185d5b6a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-758904858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f28be8f0598d98586165e832081f030e185d5b6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944",
"triggerID" : "f28be8f0598d98586165e832081f030e185d5b6a",
"triggerType" : "PUSH"
}, {
"hash" : "e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12072",
"triggerID" : "e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5",
"triggerType" : "PUSH"
}, {
"hash" : "8424254a9dee042e3ec96d21f7541dc25ee9bd6c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12075",
"triggerID" : "8424254a9dee042e3ec96d21f7541dc25ee9bd6c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8424254a9dee042e3ec96d21f7541dc25ee9bd6c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12075)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-758904858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f28be8f0598d98586165e832081f030e185d5b6a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944",
"triggerID" : "f28be8f0598d98586165e832081f030e185d5b6a",
"triggerType" : "PUSH"
}, {
"hash" : "e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f28be8f0598d98586165e832081f030e185d5b6a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944)
* e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-758904858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f28be8f0598d98586165e832081f030e185d5b6a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944",
"triggerID" : "f28be8f0598d98586165e832081f030e185d5b6a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f28be8f0598d98586165e832081f030e185d5b6a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-771497779
Sorry for coming back so late to this PR. Code-wise, it looks mostly fine. I would add a complete code review later.
However, I'd like to clarify first, why we want to have the old implementation in Flink master at all. From my perspective, this is instant legacy. So there needs to be a strong reason to have it compared to merge only the new interfaces.
Possible reasons could include features that cannot be supported with the new PulsarSink. In general, when would a user choose the old implementation over the new implementation given that the new sink interface is quite stable in Flink 1.13?
I'm duplicating the reply to the Source PR as the answer may be different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-758904858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f28be8f0598d98586165e832081f030e185d5b6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944",
"triggerID" : "f28be8f0598d98586165e832081f030e185d5b6a",
"triggerType" : "PUSH"
}, {
"hash" : "e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12072",
"triggerID" : "e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5",
"triggerType" : "PUSH"
}, {
"hash" : "8424254a9dee042e3ec96d21f7541dc25ee9bd6c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12075",
"triggerID" : "8424254a9dee042e3ec96d21f7541dc25ee9bd6c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12072)
* 8424254a9dee042e3ec96d21f7541dc25ee9bd6c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12075)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-775908877
I'm closing this PR for the time being similar to #14622 . If we still see a need for it after having the new source in, we can still reopen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise closed pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
AHeise closed pull request #14623:
URL: https://github.com/apache/flink/pull/14623
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] jianyun8023 commented on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-758891364
The pr depends on #14622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-758904858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f28be8f0598d98586165e832081f030e185d5b6a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944",
"triggerID" : "f28be8f0598d98586165e832081f030e185d5b6a",
"triggerType" : "PUSH"
}, {
"hash" : "e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12072",
"triggerID" : "e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5",
"triggerType" : "PUSH"
}, {
"hash" : "8424254a9dee042e3ec96d21f7541dc25ee9bd6c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12075",
"triggerID" : "8424254a9dee042e3ec96d21f7541dc25ee9bd6c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f28be8f0598d98586165e832081f030e185d5b6a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944)
* e3cce528b5072bc45f8e6aa4cd94f49cf85a94d5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12072)
* 8424254a9dee042e3ec96d21f7541dc25ee9bd6c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12075)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-758904858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f28be8f0598d98586165e832081f030e185d5b6a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944",
"triggerID" : "f28be8f0598d98586165e832081f030e185d5b6a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f28be8f0598d98586165e832081f030e185d5b6a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11944)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] jianyun8023 commented on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-772404537
> Sorry for coming back so late to this PR. Code-wise, it looks mostly fine. I would add a complete code review later.
>
> However, I'd like to clarify first, why we want to have the old implementation in Flink master at all. From my perspective, this is instant legacy. So there needs to be a strong reason to have it compared to merge only the new interfaces.
>
> Possible reasons could include features that cannot be supported with the new PulsarSink. In general, when would a user choose the old implementation over the new implementation given that the new sink interface is quite stable in Flink 1.13?
>
> I'm duplicating the reply to the Source PR as the answer may be different.
I think the new version of Sink interface is still in iteration and not reliable enough. Providing an older implementation may be a better option for users.
We are following up on the new Sink and will submit it up as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14623: [FLINK-20728][connector] Pulsar SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14623:
URL: https://github.com/apache/flink/pull/14623#issuecomment-758892207
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit dbf3ad8f6cd43f3358089eaa8e0989073dcd8468 (Tue Jan 12 19:44:04 UTC 2021)
**Warnings:**
* **3 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20728).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org