You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bridges-dev@portals.apache.org by "Martin Marinschek (JIRA)" <br...@portals.apache.org> on 2007/09/01 10:53:19 UTC
[jira] Created: (PB-73) Cumulative patch for better storing the
ViewRoot, disabling calling restoreState on the ViewRoot, and better
SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
Cumulative patch for better storing the ViewRoot, disabling calling restoreState on the ViewRoot, and better SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: PB-73
URL: https://issues.apache.org/jira/browse/PB-73
Project: Portals Bridges
Issue Type: Bug
Components: jsf
Affects Versions: 1.0
Reporter: Martin Marinschek
This patch tries to resolve three issues with the current bridge. It has been created by Thomas Spiegl, Bernhard Huemer and me (just to do the honours ;).
1) The UIViewRoot is directly put into the session - this doesn't fly if load-balancing is switched on and the session is serialized between servers, as no JSF-component is serializable (instead, it implements state-holder, and one has to call the appropriate methods restoreState/saveState, and additionally save the tree-structure.
2) In the FacesPortlet, a superfluous call to restoreState is happening - if the UIViewRoot is properly restored, restoreState should not be called anymore
3) the SessionMap/RequestParameterMap etc. will only work if behind a portlet. In some cases, the JSF-app might run both behind a portlet and a servlet
regards,
Martin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Resolved: (PB-73) Cumulative patch for better storing the
ViewRoot, disabling calling restoreState on the ViewRoot, and better
SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
Posted by "David Sean Taylor (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Sean Taylor resolved PB-73.
---------------------------------
Resolution: Incomplete
I have not received a patch after waiting 1 month. I am resolving this as incomplete.
> Cumulative patch for better storing the ViewRoot, disabling calling restoreState on the ViewRoot, and better SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PB-73
> URL: https://issues.apache.org/jira/browse/PB-73
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Martin Marinschek
> Assignee: David Sean Taylor
> Attachments: jsf-portlet-bridge.patch
>
>
> This patch tries to resolve three issues with the current bridge. It has been created by Thomas Spiegl, Bernhard Huemer and me (just to do the honours ;).
> 1) The UIViewRoot is directly put into the session - this doesn't fly if load-balancing is switched on and the session is serialized between servers, as no JSF-component is serializable (instead, it implements state-holder, and one has to call the appropriate methods restoreState/saveState, and additionally save the tree-structure.
> 2) In the FacesPortlet, a superfluous call to restoreState is happening - if the UIViewRoot is properly restored, restoreState should not be called anymore
> 3) the SessionMap/RequestParameterMap etc. will only work if behind a portlet. In some cases, the JSF-app might run both behind a portlet and a servlet
> regards,
> Martin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Work started: (PB-73) Cumulative patch for better storing
the ViewRoot, disabling calling restoreState on the ViewRoot, and better
SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
Posted by "David Sean Taylor (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on PB-73 started by David Sean Taylor.
> Cumulative patch for better storing the ViewRoot, disabling calling restoreState on the ViewRoot, and better SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PB-73
> URL: https://issues.apache.org/jira/browse/PB-73
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Martin Marinschek
> Assignee: David Sean Taylor
> Attachments: jsf-portlet-bridge.patch
>
>
> This patch tries to resolve three issues with the current bridge. It has been created by Thomas Spiegl, Bernhard Huemer and me (just to do the honours ;).
> 1) The UIViewRoot is directly put into the session - this doesn't fly if load-balancing is switched on and the session is serialized between servers, as no JSF-component is serializable (instead, it implements state-holder, and one has to call the appropriate methods restoreState/saveState, and additionally save the tree-structure.
> 2) In the FacesPortlet, a superfluous call to restoreState is happening - if the UIViewRoot is properly restored, restoreState should not be called anymore
> 3) the SessionMap/RequestParameterMap etc. will only work if behind a portlet. In some cases, the JSF-app might run both behind a portlet and a servlet
> regards,
> Martin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Assigned: (PB-73) Cumulative patch for better storing the
ViewRoot, disabling calling restoreState on the ViewRoot, and better
SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
Posted by "David Sean Taylor (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Sean Taylor reassigned PB-73:
-----------------------------------
Assignee: David Sean Taylor
> Cumulative patch for better storing the ViewRoot, disabling calling restoreState on the ViewRoot, and better SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PB-73
> URL: https://issues.apache.org/jira/browse/PB-73
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Martin Marinschek
> Assignee: David Sean Taylor
> Attachments: jsf-portlet-bridge.patch
>
>
> This patch tries to resolve three issues with the current bridge. It has been created by Thomas Spiegl, Bernhard Huemer and me (just to do the honours ;).
> 1) The UIViewRoot is directly put into the session - this doesn't fly if load-balancing is switched on and the session is serialized between servers, as no JSF-component is serializable (instead, it implements state-holder, and one has to call the appropriate methods restoreState/saveState, and additionally save the tree-structure.
> 2) In the FacesPortlet, a superfluous call to restoreState is happening - if the UIViewRoot is properly restored, restoreState should not be called anymore
> 3) the SessionMap/RequestParameterMap etc. will only work if behind a portlet. In some cases, the JSF-app might run both behind a portlet and a servlet
> regards,
> Martin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Updated: (PB-73) Cumulative patch for better storing the
ViewRoot, disabling calling restoreState on the ViewRoot, and better
SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
Posted by "Martin Marinschek (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Marinschek updated PB-73:
--------------------------------
Attachment: jsf-portlet-bridge.patch
All contributors have Apache CLAs on file.
> Cumulative patch for better storing the ViewRoot, disabling calling restoreState on the ViewRoot, and better SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PB-73
> URL: https://issues.apache.org/jira/browse/PB-73
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Martin Marinschek
> Attachments: jsf-portlet-bridge.patch
>
>
> This patch tries to resolve three issues with the current bridge. It has been created by Thomas Spiegl, Bernhard Huemer and me (just to do the honours ;).
> 1) The UIViewRoot is directly put into the session - this doesn't fly if load-balancing is switched on and the session is serialized between servers, as no JSF-component is serializable (instead, it implements state-holder, and one has to call the appropriate methods restoreState/saveState, and additionally save the tree-structure.
> 2) In the FacesPortlet, a superfluous call to restoreState is happening - if the UIViewRoot is properly restored, restoreState should not be called anymore
> 3) the SessionMap/RequestParameterMap etc. will only work if behind a portlet. In some cases, the JSF-app might run both behind a portlet and a servlet
> regards,
> Martin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Commented: (PB-73) Cumulative patch for better storing the
ViewRoot, disabling calling restoreState on the ViewRoot, and better
SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
Posted by "Ate Douma (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532472 ]
Ate Douma commented on PB-73:
-----------------------------
Martin,
I applied your patch and tested it against our bridges jsf-demo application but encountered some problems.
First of all, the new ViewStateManager.restoreViewState method should check against a null viewState parameter as with the CalendarPortlet it thew an NPE.
But even after fixing that myself it didn't work: the managed bean (CalendarBean) is never invoked on an action.
I don't have time to further investigate this so could you please check this and provide a patch which at least works for our simple test portlets?
Regards,
Ate
> Cumulative patch for better storing the ViewRoot, disabling calling restoreState on the ViewRoot, and better SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PB-73
> URL: https://issues.apache.org/jira/browse/PB-73
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Martin Marinschek
> Assignee: David Sean Taylor
> Attachments: jsf-portlet-bridge.patch
>
>
> This patch tries to resolve three issues with the current bridge. It has been created by Thomas Spiegl, Bernhard Huemer and me (just to do the honours ;).
> 1) The UIViewRoot is directly put into the session - this doesn't fly if load-balancing is switched on and the session is serialized between servers, as no JSF-component is serializable (instead, it implements state-holder, and one has to call the appropriate methods restoreState/saveState, and additionally save the tree-structure.
> 2) In the FacesPortlet, a superfluous call to restoreState is happening - if the UIViewRoot is properly restored, restoreState should not be called anymore
> 3) the SessionMap/RequestParameterMap etc. will only work if behind a portlet. In some cases, the JSF-app might run both behind a portlet and a servlet
> regards,
> Martin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Commented: (PB-73) Cumulative patch for better storing the
ViewRoot, disabling calling restoreState on the ViewRoot, and better
SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
Posted by "Martin Marinschek (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532474 ]
Martin Marinschek commented on PB-73:
-------------------------------------
Hi Ate,
sure, I'll rewrite the patch.
regards,
Martin
> Cumulative patch for better storing the ViewRoot, disabling calling restoreState on the ViewRoot, and better SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PB-73
> URL: https://issues.apache.org/jira/browse/PB-73
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Martin Marinschek
> Assignee: David Sean Taylor
> Attachments: jsf-portlet-bridge.patch
>
>
> This patch tries to resolve three issues with the current bridge. It has been created by Thomas Spiegl, Bernhard Huemer and me (just to do the honours ;).
> 1) The UIViewRoot is directly put into the session - this doesn't fly if load-balancing is switched on and the session is serialized between servers, as no JSF-component is serializable (instead, it implements state-holder, and one has to call the appropriate methods restoreState/saveState, and additionally save the tree-structure.
> 2) In the FacesPortlet, a superfluous call to restoreState is happening - if the UIViewRoot is properly restored, restoreState should not be called anymore
> 3) the SessionMap/RequestParameterMap etc. will only work if behind a portlet. In some cases, the JSF-app might run both behind a portlet and a servlet
> regards,
> Martin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Commented: (PB-73) Cumulative patch for better storing the
ViewRoot, disabling calling restoreState on the ViewRoot, and better
SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
Posted by "Martin Marinschek (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524263 ]
Martin Marinschek commented on PB-73:
-------------------------------------
Two more things:
1) the pom.xml also includes the sources of the jsf-portlet-bridge in the distribution with this version and sets two dependencies (JSP-API and JSF-API to provided)
2) the portlet underlying this bridge is being passed on as a request-parameter, so that afterwards the portlet-name can be retrieved. Eventually, there might be a better solution for this, but we didn't find one.
regards,
Martin
> Cumulative patch for better storing the ViewRoot, disabling calling restoreState on the ViewRoot, and better SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PB-73
> URL: https://issues.apache.org/jira/browse/PB-73
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Martin Marinschek
> Attachments: jsf-portlet-bridge.patch
>
>
> This patch tries to resolve three issues with the current bridge. It has been created by Thomas Spiegl, Bernhard Huemer and me (just to do the honours ;).
> 1) The UIViewRoot is directly put into the session - this doesn't fly if load-balancing is switched on and the session is serialized between servers, as no JSF-component is serializable (instead, it implements state-holder, and one has to call the appropriate methods restoreState/saveState, and additionally save the tree-structure.
> 2) In the FacesPortlet, a superfluous call to restoreState is happening - if the UIViewRoot is properly restored, restoreState should not be called anymore
> 3) the SessionMap/RequestParameterMap etc. will only work if behind a portlet. In some cases, the JSF-app might run both behind a portlet and a servlet
> regards,
> Martin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org