You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/11/28 09:19:40 UTC

[GitHub] spark pull request #21004: [SPARK-23896][SQL]Improve PartitioningAwareFileIn...

Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21004#discussion_r236998030
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningAwareFileIndex.scala ---
    @@ -126,35 +126,32 @@ abstract class PartitioningAwareFileIndex(
         val caseInsensitiveOptions = CaseInsensitiveMap(parameters)
         val timeZoneId = caseInsensitiveOptions.get(DateTimeUtils.TIMEZONE_OPTION)
           .getOrElse(sparkSession.sessionState.conf.sessionLocalTimeZone)
    -
    -    userPartitionSchema match {
    +    val inferredPartitionSpec = PartitioningUtils.parsePartitions(
    +      leafDirs,
    +      typeInference = sparkSession.sessionState.conf.partitionColumnTypeInferenceEnabled,
    --- End diff --
    
    this is causing a behavior change in Spark 2.4.0 reported in SPARK-26188. Why did we need this change?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org