[jira] [Work logged] (KNOX-2204) KnoxLine NPE list datasources when directories don't exist

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KNOX-2204?focusedWorklogId=378637&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378637 ]

ASF GitHub Bot logged work on KNOX-2204:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jan/20 04:53
            Start Date: 29/Jan/20 04:53
    Worklog Time Spent: 10m 
      Work Description: lmccay commented on pull request #246: KNOX-2204 - KnoxLine NPE list datasources when directories don't exist
URL: https://github.com/apache/knox/pull/246
 
 
   ## What changes were proposed in this pull request?
   Fixes NPE when 
   
   ~/.knoxshell directories and/or no datasources persisted.
   
   Tested manually by renaming the ~/.knoxshell dir to ~/.knoxshell.bak
   knoxshell.sh knoxline
   knoxline> :ds
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 378637)
    Remaining Estimate: 0h
            Time Spent: 10m

> KnoxLine NPE list datasources when directories don't exist
> ----------------------------------------------------------
>
>                 Key: KNOX-2204
>                 URL: https://issues.apache.org/jira/browse/KNOX-2204
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: KnoxShell
>            Reporter: Larry McCay
>            Assignee: Larry McCay
>            Priority: Major
>             Fix For: 1.4.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code}
> | | ___ __ _____ _| (_)_ __ ___ 
> | |/ / '_ \ / _ \ \/ / | | '_ \ / _ \
> | <| | | | (_) > <| | | | | | __/
> |_|\_\_| |_|\___/_/\_\_|_|_| |_|\\__|
> powered by Apache Knox
> knoxline> :ds
> java.lang.NullPointerException
>  at org.apache.knox.gateway.shell.jdbc.KnoxLine.listDataSources(KnoxLine.java:135)
>  at org.apache.knox.gateway.shell.jdbc.KnoxLine.processDataSourceCommand(KnoxLine.java:110)
>  at org.apache.knox.gateway.shell.jdbc.KnoxLine.executeShell(KnoxLine.java:71)
>  at org.apache.knox.gateway.shell.jdbc.KnoxLine.execute(KnoxLine.java:51)
>  at org.apache.knox.gateway.shell.KnoxSh$KnoxLineCommand.execute(KnoxSh.java:412)
>  at org.apache.knox.gateway.shell.KnoxSh.run(KnoxSh.java:88)
>  at org.apache.knox.gateway.shell.KnoxSh.main(KnoxSh.java:427)
>  at org.apache.knox.gateway.shell.Shell.main(Shell.java:74)
> Closing any open connections ...
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)