You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/13 13:54:18 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #30325: [SPARK-33416][SQL] Avoid Hive metastore stack overflow when InSet predicate have many values
cloud-fan commented on a change in pull request #30325:
URL: https://github.com/apache/spark/pull/30325#discussion_r522963377
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -815,6 +815,15 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val HIVE_METASTORE_PARTITION_PRUNING_INSET_THRESHOLD =
+ buildStaticConf("spark.sql.hive.metastorePartitionPruningInSetThreshold")
+ .doc("The threshold of set size for InSet predicate when pruning partitions through Hive " +
+ "Metastore. Larger values may cause Hive metastore stack overflow.")
Review comment:
let's mention what happens if we exceed the size treshold.
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -815,6 +815,15 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val HIVE_METASTORE_PARTITION_PRUNING_INSET_THRESHOLD =
+ buildStaticConf("spark.sql.hive.metastorePartitionPruningInSetThreshold")
+ .doc("The threshold of set size for InSet predicate when pruning partitions through Hive " +
+ "Metastore. Larger values may cause Hive metastore stack overflow.")
Review comment:
let's mention what happens if we exceed the size threshold.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org