You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/19 00:04:17 UTC

[GitHub] [pulsar] mattisonchao opened a new pull request, #15208: [fix][transaction] Fix potentially unfinishable future.

mattisonchao opened a new pull request, #15208:
URL: https://github.com/apache/pulsar/pull/15208

   ### Motivation
   
   The relative code is as below:
   https://github.com/apache/pulsar/blob/9861dfb1208c4b6b8a1f17ef026e9af71c3e784c/pulsar-broker/src/main/java/org/apache/pulsar/broker/TransactionMetadataStoreService.java#L167-L250
   
   When `checkTopicNsOwnership ` throws an exception, it will cause the `completableFuture ` never complete.
   
   > This PR is just to fix this unfinishable future issue, after that, I will try to refactor this part of the code to make it not so complex.
   
   ### Modifications
   
   - Add `checkTopicNsOwnership` exception catch.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Documentation
   
   - [x] `no-need-doc` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #15208: [fix][transaction] Fix potentially unfinishable future.

Posted by GitBox <gi...@apache.org>.

eolivelli merged PR #15208:
URL: https://github.com/apache/pulsar/pull/15208


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org