[GitHub] [spark] itholic commented on a diff in pull request #43024: [SPARK-45246][BUILD][PS] Encourage using latest `jinja2` other than documentation build

["itholic (via GitHub)" <gi...@apache.org>]

itholic commented on code in PR #43024:
URL: https://github.com/apache/spark/pull/43024#discussion_r1332728611


##########
dev/requirements.txt:
##########
@@ -34,7 +35,9 @@ pydata_sphinx_theme
 ipython
 nbsphinx
 numpydoc
-jinja2<3.0.0
+# Commented this because we need the latest version of jinja2 for Pandas API on Spark.
+# Please manually install jinja2<3.0.0 when building the documentation.
+# jinja2<3.0.0

Review Comment:
   `(DataFrame|Series).to_latex` does not work without `jinja2>=3.1.2`
   ```python
   >>> import pyspark.pandas as ps
   >>> psdf = ps.DataFrame({"A": [1, 2, 3]})
   >>> psdf.to_latex()
   Traceback (most recent call last):
   ...
   ImportError: Pandas requires version '3.1.2' or newer of 'jinja2' (version '2.11.3' currently installed).
   ```
   But I'm okay we just keep the current status, because this is the only case for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org