You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/01/08 06:15:01 UTC

Review Request: FLUME-1824. Inflights can complete successfully even if checkpoint fails

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8875/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Split out checkpoint method to beginCheckpoint.


This addresses bug FLUME-1824.
    https://issues.apache.org/jira/browse/FLUME-1824


Diffs
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStore.java 13b50da 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java 186b15a 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java 74a2bc8 

Diff: https://reviews.apache.org/r/8875/diff/


Testing
-------

All tests pass.


Thanks,

Hari Shreedharan


Re: Review Request: FLUME-1824. Inflights can complete successfully even if checkpoint fails

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8875/#review15146
-----------------------------------------------------------

Ship it!


Ship It!

- Brock Noland


On Jan. 8, 2013, 5:15 a.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8875/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2013, 5:15 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Split out checkpoint method to beginCheckpoint.
> 
> 
> This addresses bug FLUME-1824.
>     https://issues.apache.org/jira/browse/FLUME-1824
> 
> 
> Diffs
> -----
> 
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStore.java 13b50da 
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java 186b15a 
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java 74a2bc8 
> 
> Diff: https://reviews.apache.org/r/8875/diff/
> 
> 
> Testing
> -------
> 
> All tests pass.
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>