You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "James Dyer (JIRA)" <ji...@apache.org> on 2012/09/18 19:26:07 UTC

[jira] [Created] (SOLR-3850) DIH: parameter "cacheKey" was inadvertently renamed "cachePk"

James Dyer created SOLR-3850:
--------------------------------

             Summary: DIH:  parameter "cacheKey" was inadvertently renamed "cachePk"
                 Key: SOLR-3850
                 URL: https://issues.apache.org/jira/browse/SOLR-3850
             Project: Solr
          Issue Type: Bug
    Affects Versions: 4.0-BETA, 3.6.1
            Reporter: James Dyer
            Assignee: James Dyer
             Fix For: 4.0, 3.6.2


CachedSqlEntityProcessor supports an obscure alternate to the "where" parameter.  Instead of <entity ... where='id=x.id' /> , users can use <entity ... cacheKey="id" cacheLookup="x.id" />  However, this was broken with SOLR-2382.  "cacheKey" was accidently renamed "cachePk".  For the sake of those who might be using this undocumented syntax and want to upgrade, I think it should be put back to "cacheKey".  Also, I will add documentation in the wiki.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3850) DIH: parameter "cacheKey" was inadvertently renamed "cachePk"

Posted by "James Dyer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Dyer updated SOLR-3850:
-----------------------------

    Attachment: SOLR-3850.patch

This patch also fixes 2 tests that depended on the incorrect parameter name.
                
> DIH:  parameter "cacheKey" was inadvertently renamed "cachePk"
> --------------------------------------------------------------
>
>                 Key: SOLR-3850
>                 URL: https://issues.apache.org/jira/browse/SOLR-3850
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 3.6.1, 4.0-BETA
>            Reporter: James Dyer
>            Assignee: James Dyer
>             Fix For: 4.0, 3.6.2
>
>         Attachments: SOLR-3850.patch, SOLR-3850.patch
>
>
> CachedSqlEntityProcessor supports an obscure alternate to the "where" parameter.  Instead of <entity ... where='id=x.id' /> , users can use <entity ... cacheKey="id" cacheLookup="x.id" />  However, this was broken with SOLR-2382.  "cacheKey" was accidently renamed "cachePk".  For the sake of those who might be using this undocumented syntax and want to upgrade, I think it should be put back to "cacheKey".  Also, I will add documentation in the wiki.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3850) DIH: parameter "cacheKey" was inadvertently renamed "cachePk"

Posted by "James Dyer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Dyer updated SOLR-3850:
-----------------------------

    Attachment: SOLR-3850.patch

I plan to commit this to trunk, 4.x & 3.x shortly.
                
> DIH:  parameter "cacheKey" was inadvertently renamed "cachePk"
> --------------------------------------------------------------
>
>                 Key: SOLR-3850
>                 URL: https://issues.apache.org/jira/browse/SOLR-3850
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 3.6.1, 4.0-BETA
>            Reporter: James Dyer
>            Assignee: James Dyer
>             Fix For: 4.0, 3.6.2
>
>         Attachments: SOLR-3850.patch
>
>
> CachedSqlEntityProcessor supports an obscure alternate to the "where" parameter.  Instead of <entity ... where='id=x.id' /> , users can use <entity ... cacheKey="id" cacheLookup="x.id" />  However, this was broken with SOLR-2382.  "cacheKey" was accidently renamed "cachePk".  For the sake of those who might be using this undocumented syntax and want to upgrade, I think it should be put back to "cacheKey".  Also, I will add documentation in the wiki.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (SOLR-3850) DIH: parameter "cacheKey" was inadvertently renamed "cachePk"

Posted by "James Dyer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Dyer resolved SOLR-3850.
------------------------------

    Resolution: Fixed

committed.

Trunk: r1387681
4x: r1387683
3x: r1387694

Also updated the wiki documenting this alternate syntax with a warning about the parameter name being wrong in 3.6, 3.6.1, 4.0-alpha & 4.0-beta.
                
> DIH:  parameter "cacheKey" was inadvertently renamed "cachePk"
> --------------------------------------------------------------
>
>                 Key: SOLR-3850
>                 URL: https://issues.apache.org/jira/browse/SOLR-3850
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 3.6.1, 4.0-BETA
>            Reporter: James Dyer
>            Assignee: James Dyer
>             Fix For: 4.0, 3.6.2
>
>         Attachments: SOLR-3850.patch, SOLR-3850.patch
>
>
> CachedSqlEntityProcessor supports an obscure alternate to the "where" parameter.  Instead of <entity ... where='id=x.id' /> , users can use <entity ... cacheKey="id" cacheLookup="x.id" />  However, this was broken with SOLR-2382.  "cacheKey" was accidently renamed "cachePk".  For the sake of those who might be using this undocumented syntax and want to upgrade, I think it should be put back to "cacheKey".  Also, I will add documentation in the wiki.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org