You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2017/07/11 17:10:31 UTC
[GitHub] beam pull request #3542: Remove dead (and wrong) viewFromProto overload
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/3542
Remove dead (and wrong) viewFromProto overload
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
@tgroh I failed to actually delete this unused method in resolving conflicts on #3509.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam viewFromProto
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3542
----
commit 5f8e4e1fca957c140d4bea62929d91bbe4dd8693
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-07-11T17:09:12Z
Remove dead (and wrong) viewFromProto overload
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #3542: Remove dead (and wrong) viewFromProto overload
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/3542
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---