You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/19 12:49:01 UTC
[jira] [Commented] (FLINK-7228) Harden
HistoryServerStaticFileHandlerTest
[ https://issues.apache.org/jira/browse/FLINK-7228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093019#comment-16093019 ]
ASF GitHub Bot commented on FLINK-7228:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4366
[FLINK-7228] [history] Use free port in HistoryServerStaticFileServer…
This PR changes `HistoryServerStaticFileServerHandlerTest#testRespondWithFile` to select a free port.
Previously the test always tried to use port 8081, which could lead to test failures if this port was taken, for example by another web interface.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7228
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4366.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4366
----
commit 55d972fe580323836971151acee81e858433b859
Author: zentol <ch...@apache.org>
Date: 2017-07-19T12:45:49Z
[FLINK-7228] [history] Use free port in HistoryServerStaticFileServerHandlerTest
----
> Harden HistoryServerStaticFileHandlerTest
> -----------------------------------------
>
> Key: FLINK-7228
> URL: https://issues.apache.org/jira/browse/FLINK-7228
> Project: Flink
> Issue Type: Improvement
> Components: Tests, Webfrontend
> Affects Versions: 1.3.1, 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Minor
> Fix For: 1.4.0, 1.3.2
>
>
> We can harden the test to use a free port instead of the hard-coded 8081.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)