[GitHub] [pulsar-client-python] eolivelli commented on a diff in pull request #1: PIP-209: Compile Python client wrapper

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #1:
URL: https://github.com/apache/pulsar-client-python/pull/1#discussion_r983319691


##########
build-mac-wheels.sh:
##########
@@ -246,6 +247,43 @@ else
     echo "Using cached LibCurl"
 fi
 
+###############################################################################
+if [ ! -f apache-pulsar-${PULSAR_VERSION}-src/.done ]; then
+    echo "Building Pulsar C++ client - ${PULSAR_VERSION}"
+    curl -O -L  https://archive.apache.org/dist/pulsar/pulsar-${PULSAR_VERSION}/apache-pulsar-${PULSAR_VERSION}-src.tar.gz

Review Comment:
   we should probably add some validation of the integrity of the archive
   
   
   and also provide a way to pass a custom .tar.gz, in order to ease development/testing with a different version
   maybe making the full URL configurable will help
   
   we can do these improvements as a follow up patch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org