[jira] [Commented] (FLINK-26766) Mistake in ChangelogStateHandleStreamImpl#getIntersection

["Roman Khachatryan (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-26766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509687#comment-17509687 ] 

Roman Khachatryan commented on FLINK-26766:
-------------------------------------------

Hi [~Feifan Wang], you are right, thanks for noticing this.
I think the impact is limited to inefficient rescaling (handles are sent unnecessarily); because of the [check|https://github.com/apache/flink/blob/b643feedc88e660df7c333870454763f011d3f01/flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/restore/ChangelogBackendLogApplier.java#L95] on TM, it shouldn't affect correctness.

> Mistake in ChangelogStateHandleStreamImpl#getIntersection
> ---------------------------------------------------------
>
>                 Key: FLINK-26766
>                 URL: https://issues.apache.org/jira/browse/FLINK-26766
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / State Backends
>            Reporter: Feifan Wang
>            Priority: Critical
>
>  
> Maybe mistake in ChangelogStateHandleStreamImpl :
> {code:java}
> public KeyedStateHandle getIntersection(KeyGroupRange keyGroupRange) {
>     KeyGroupRange offsets = keyGroupRange.getIntersection(keyGroupRange);
>     // ......
> } {code}
> I guess should be :
> KeyGroupRange offsets = {color:#de350b}this{color}.keyGroupRange.getIntersection(keyGroupRange);
>  
> Hi [~roman] , can you help confirm that ?
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)