You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/09/24 09:05:17 UTC

[GitHub] [thrift] kpy3 opened a new pull request, #2677: WIP: THRIFT-5635: update erlang client

kpy3 opened a new pull request, #2677:
URL: https://github.com/apache/thrift/pull/2677

   Try to update Erlang client with modern features and tools
   - Added useful compiler, ref and dialyzer flags
   - Added types to record fields in states
   - Added missing specs for function
   - Reformat source code using erlfmt (de-facto standard in Erlang world)
   - Replace deprecated and removed syntax constructs and functions with counterparts 
   
   - [x] https://issues.apache.org/jira/browse/THRIFT-5635
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [ ] Did you squash your changes to a single commit?  (not required, but preferred)
   - [ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2677: WIP: THRIFT-5635: update erlang client

Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2677:
URL: https://github.com/apache/thrift/pull/2677#issuecomment-1256920987

   Much appreciated!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2677: WIP: THRIFT-5635: update erlang client

Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #2677:
URL: https://github.com/apache/thrift/pull/2677#issuecomment-1631448775

   Is this still draft?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] kpy3 commented on pull request #2677: WIP: THRIFT-5635: update erlang client

Posted by "kpy3 (via GitHub)" <gi...@apache.org>.
kpy3 commented on PR #2677:
URL: https://github.com/apache/thrift/pull/2677#issuecomment-1631947507

   Hi @Jens-G,
   
   in general I've made almost all planned changes, some missed tweaks for multiplexer can be added via another PR, I think. So in my opinion this PR is ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G closed pull request #2677: THRIFT-5635: update erlang client

Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G closed pull request #2677: THRIFT-5635: update erlang client
URL: https://github.com/apache/thrift/pull/2677


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org