You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "eschutho (via GitHub)" <gi...@apache.org> on 2023/11/02 23:58:14 UTC
Re: [PR] fix: add validation on tag name to have name + onDelete refresh list view [superset]
eschutho commented on code in PR #25831:
URL: https://github.com/apache/superset/pull/25831#discussion_r1380903886
##########
superset-frontend/src/features/tags/TagModal.tsx:
##########
@@ -222,10 +222,14 @@ const TagModal: React.FC<TagModalProps> = ({
name: tagName,
objects_to_tag: [...dashboards, ...charts, ...savedQueries],
},
- }).then(({ json = {} }) => {
- refreshData();
- addSuccessToast(t('Tag updated'));
- });
+ })
+ .then(({ json = {} }) => {
+ refreshData();
+ addSuccessToast(t('Tag updated'));
+ })
+ .catch(err => {
+ addDangerToast(err.message ? err.message : 'Error Updating Tag');
Review Comment:
```suggestion
addDangerToast(err.message || 'Error Updating Tag');
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org