You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/03/20 18:44:38 UTC
[Bug 121925] New: Crash when Crtl+Shift+Del at end of table
https://issues.apache.org/ooo/show_bug.cgi?id=121925
Bug ID: 121925
Issue Type: DEFECT
Summary: Crash when Crtl+Shift+Del at end of table
Classification: Application
Product: Writer
Version: AOO400-dev
Hardware: PC
OS: Windows 7
Status: CONFIRMED
Severity: major
Priority: P3
Component: editing
Assignee: issues@openoffice.apache.org
Reporter: rb.henschel@t-online.de
CC: issues@openoffice.apache.org
In AOO3.4.1 it is possible to delete the paragraph which follows a table by
going to end of right, bottom cell and then press Ctrl+Shift+Delete. If you do
this in AOO4.0dev, it crashes.
I know from bug 94879, that deleting the paragraph is currently not persistent
over save - reload. But you need this feature, if you want to merge two tables.
Only tables which are adjacent, without paragraph between them can be merged.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
|g |
--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
ALG: Grepping, preparing possible solution
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsc@apache.org
Flags|4.0.0_release_blocker? |4.0.0_release_blocker+
--- Comment #3 from jsc@apache.org ---
set showstopper flag
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
review requested: [Bug 121925] Crash when Crtl+Shift+Del at end of
table : [Attachment 80905] Possible solution
Posted by bu...@apache.org.
Armin Le Grand <Ar...@me.com> has asked Oliver-Rainer Wittmann
<or...@apache.org> for review:
Bug 121925: Crash when Crtl+Shift+Del at end of table
https://issues.apache.org/ooo/show_bug.cgi?id=121925
Attachment 80905: Possible solution
https://issues.apache.org/ooo/attachment.cgi?id=80905&action=edit
------- Additional Comments from Armin Le Grand <Ar...@me.com>
ALG: With the added patch the crash is gone. The action deletes the table, and
UNDO adds it again.
Checked with Symphony; does also not happen there. in
sw/source/core/edit/eddel.cxx it has various extensions in
SwEditShell::DeleteSel, see xAdjustCursorForSpecialSelection and others. The
result of the action is the same, the table gets deleted, UNDO brings it back.
Only diff is that the selection is on all 4 table cells, while with my patch
it's only in the first.
@ORW: Could you have a lok please, you are the SW specialist.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #22 from Regina Henschel <rb...@t-online.de> ---
I have build r1497734 on Windows 7. Ctrl+Shift+Del at end of table now works
without crash and as it should.
For Bug 119652: Ctrl+Shift+Backspace works without any assertion and as it
should. Undo works at is should.
No problems with charts based on that table.
So fix verified for r1497734 for Windows 7.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
--- Comment #19 from Oliver-Rainer Wittmann <or...@apache.org> ---
I have found a solution.
I will revert the changes of bug 119652 to fix this issue. Bug 119652 will be
fixed with a different solution.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
--- Comment #10 from Oliver-Rainer Wittmann <or...@apache.org> ---
(In reply to Regina Henschel from comment #9)
> Hi, please check this scenario: Make a table with values and then create a
> chart, which depends on this table. If I delete the table and then undo it,
> the table comes back, but the chart looses its connection to the table.
Hi Regina, could you please submit a new issue for this problem. Thx in
advance.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
--- Comment #9 from Regina Henschel <rb...@t-online.de> ---
Hi, please check this scenario: Make a table with values and then create a
chart, which depends on this table. If I delete the table and then undo it, the
table comes back, but the chart looses its connection to the table.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
fanyuzhen@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fanyuzhen@gmail.com
Flags| |4.0.0_release_blocker?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
4.0.0_release_blocker granted: [Bug 121925] Crash when
Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
jsc@apache.org has granted Armin Le Grand <Ar...@me.com>'s request for
4.0.0_release_blocker:
Bug 121925: Crash when Crtl+Shift+Del at end of table
https://issues.apache.org/ooo/show_bug.cgi?id=121925
------- Additional Comments from jsc@apache.org
set showstopper flag again
review canceled: [Bug 121925] Crash when Crtl+Shift+Del at end of
table : [Attachment 80905] Possible solution
Posted by bu...@apache.org.
Oliver-Rainer Wittmann <or...@apache.org> has canceled Armin Le Grand
<Ar...@me.com>'s request for review:
Bug 121925: Crash when Crtl+Shift+Del at end of table
https://issues.apache.org/ooo/show_bug.cgi?id=121925
Attachment 80905: Possible solution
https://issues.apache.org/ooo/attachment.cgi?id=80905&action=edit
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
--- Comment #23 from Oliver-Rainer Wittmann <or...@apache.org> ---
(In reply to Regina Henschel from comment #22)
> I have build r1497734 on Windows 7. Ctrl+Shift+Del at end of table now works
> without crash and as it should.
>
> For Bug 119652: Ctrl+Shift+Backspace works without any assertion and as it
> should. Undo works at is should.
>
> No problems with charts based on that table.
>
> So fix verified for r1497734 for Windows 7.
Thx for the verification
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |ACCEPTED
CC| |Armin.Le.Grand@me.com
Flags|4.0.0_release_blocker+ |4.0.0_release_blocker?
--- Comment #4 from Armin Le Grand <Ar...@me.com> ---
ALG: Ollks like in SwEditShell::DeleteSel the SwNode rEndNd gets deleted (since
it's a forward delete), but the method is not prepared the rEndNd to get zero
(what it gets). Checking further...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
--- Comment #12 from Oliver-Rainer Wittmann <or...@apache.org> ---
The result of Ctrl-Shift-Del at the end of table should delete the paragraph
following the table. Thus, if the patch deletes the table by Ctrl-Shift-Del,
then it does not solve the crash correctly.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|Armin.Le.Grand@me.com |orw@apache.org
--- Comment #7 from Oliver-Rainer Wittmann <or...@apache.org> ---
Taking over to review the provided patch
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #80905|0 |1
is obsolete| |
Attachment #80905|review?(orw@apache.org) |
Flags| |
--- Comment #16 from Oliver-Rainer Wittmann <or...@apache.org> ---
Created attachment 80915
--> https://issues.apache.org/ooo/attachment.cgi?id=80915&action=edit
patch to revert changes from issue 119652
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
Andre <aw...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |awf.aoo@googlemail.com
--- Comment #2 from Andre <aw...@googlemail.com> ---
Crash takes place in SwEditShell::DeleteSel(). In
sw/source/core/edit/eddel.cxx:82 where a NULL reference is accessed. This
reference is created on the lines directly above probably from a NULL pointer
that is not checked.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
brinzing <ol...@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oliver.brinzing@gmx.de
--- Comment #1 from brinzing <ol...@gmx.de> ---
.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
--- Comment #20 from SVN Robot <sv...@dev.null.org> ---
"orw" committed SVN revision 1497274 into trunk:
121925: fixed by reverting change for issue 119652
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
--- Comment #11 from Regina Henschel <rb...@t-online.de> ---
It is not about a new issue, but when the patch is applied, it should be
possible to use Ctrl-Shift-Del and does not loose the chart. It is possible in
AOO3.4.1. I'm cautious because Armin wrote "The result of the action is the
same, the table gets deleted, UNDO brings it back." and therefore tested what a
direct table delete and undo does.
I have applied the patch to r1492861 and now it does not crash, but the table
is completely deleted. It is a debug build and not clean, so it might work
nevertheless.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
--- Comment #18 from Oliver-Rainer Wittmann <or...@apache.org> ---
(In reply to Regina Henschel from comment #17)
> Hi Oliver, I have applied your new patch. Result:
> This issue:
> Ctrl-Shift-Del works without problems to delete paragraph after table. Undo
> the action works correct. I have tested in addition, whether a chart is
> effected. It is not, charts retain their data range reference.
>
> Bug 119652:
> Ctrl-Shift-Backspace is connected to the action "Delete to paragraph start".
> This works, when there is text in cell A1. But when cell A1 is empty, the
> command deletes the text before the cell and leaves the cell A1 in a wrong
> state. Cell A1 is not reachable, neither with mouse nor with arrow keys or
> tab key and it has no pilcrow sign. Undo in this state gives a second
> paragraph in cell B1 and assertions:
>
> Error: Assertion failed
> ==================
> FILE : c:/AOO_2013_06_08/trunk/main/sw/source/core/frmedt/tblsel.cxx
> at line 1854
> ERROR : "MakeSelUnions with pStart or pEnd not in CellFrm"
>
> followed by endless assertions:
>
> Error: Assertion failed
> ==================
> FILE : c:/AOO_2013_06_08/trunk/main/sw/source/core/crsr/trvltbl.cxx at
> line 754
> ERROR : "kein Frame zur Box"
> Error: C++ exception caught!
Regina, thank your very much. You opened my eyes. I tried to reproduce 119652
by hitting Ctrl-Shift-Del. Somehow I was not able to read. Thus, I am back at
the code to fix both issues.
--
You are receiving this mail because:
You are on the CC list for the bug.
4.0.0_release_blocker requested: [Bug 121925] Crash when
Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
Armin Le Grand <Ar...@me.com> has asked for 4.0.0_release_blocker:
Bug 121925: Crash when Crtl+Shift+Del at end of table
https://issues.apache.org/ooo/show_bug.cgi?id=121925
------- Additional Comments from Armin Le Grand <Ar...@me.com>
ALG: Ollks like in SwEditShell::DeleteSel the SwNode rEndNd gets deleted (since
it's a forward delete), but the method is not prepared the rEndNd to get zero
(what it gets). Checking further...
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |AOO 4.0
--- Comment #21 from Oliver-Rainer Wittmann <or...@apache.org> ---
fixed on trunk for AOO 4.0 by reverting the changes from bug 119652 - revision
1497274
Regina: It would be great, if you could have a look and could verify this fix
and the new fix for 119652. Thx in advance.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
--- Comment #14 from Oliver-Rainer Wittmann <or...@apache.org> ---
defect introduced by fix for bug 119652
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
--- Comment #17 from Regina Henschel <rb...@t-online.de> ---
Hi Oliver, I have applied your new patch. Result:
This issue:
Ctrl-Shift-Del works without problems to delete paragraph after table. Undo the
action works correct. I have tested in addition, whether a chart is effected.
It is not, charts retain their data range reference.
Bug 119652:
Ctrl-Shift-Backspace is connected to the action "Delete to paragraph start".
This works, when there is text in cell A1. But when cell A1 is empty, the
command deletes the text before the cell and leaves the cell A1 in a wrong
state. Cell A1 is not reachable, neither with mouse nor with arrow keys or tab
key and it has no pilcrow sign. Undo in this state gives a second paragraph in
cell B1 and assertions:
Error: Assertion failed
==================
FILE : c:/AOO_2013_06_08/trunk/main/sw/source/core/frmedt/tblsel.cxx at
line 1854
ERROR : "MakeSelUnions with pStart or pEnd not in CellFrm"
followed by endless assertions:
Error: Assertion failed
==================
FILE : c:/AOO_2013_06_08/trunk/main/sw/source/core/crsr/trvltbl.cxx at
line 754
ERROR : "kein Frame zur Box"
Error: C++ exception caught!
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #80905| |review?(orw@apache.org)
Flags| |
CC| |orw@apache.org
--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
Created attachment 80905
--> https://issues.apache.org/ooo/attachment.cgi?id=80905&action=edit
Possible solution
ALG: With the added patch the crash is gone. The action deletes the table, and
UNDO adds it again.
Checked with Symphony; does also not happen there. in
sw/source/core/edit/eddel.cxx it has various extensions in
SwEditShell::DeleteSel, see xAdjustCursorForSpecialSelection and others. The
result of the action is the same, the table gets deleted, UNDO brings it back.
Only diff is that the selection is on all 4 table cells, while with my patch
it's only in the first.
@ORW: Could you have a lok please, you are the SW specialist.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|4.0.0_release_blocker? |4.0.0_release_blocker+
--- Comment #8 from jsc@apache.org ---
set showstopper flag again
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |119652
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
--- Comment #15 from Oliver-Rainer Wittmann <or...@apache.org> ---
I reverted in my local environment the fix of bug 119652.
--> this issue is fixed and bug 119652 also does not occur.
I will attach a corresponding patch.
I also could not reproduce bug 119652 in AOO 3.4.
Regina: Could you do me a favor and verify my patch and also check, if bug
119652 is still solved? Thx in advance. (no clean build will be needed for this
patch.)
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 121925] Crash when Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121925
--- Comment #13 from Regina Henschel <rb...@t-online.de> ---
Same wrong behavior with a clean build of r1492861 :(
--
You are receiving this mail because:
You are on the CC list for the bug.
4.0.0_release_blocker granted: [Bug 121925] Crash when
Crtl+Shift+Del at end of table
Posted by bu...@apache.org.
jsc@apache.org has granted fanyuzhen@gmail.com's request for
4.0.0_release_blocker:
Bug 121925: Crash when Crtl+Shift+Del at end of table
https://issues.apache.org/ooo/show_bug.cgi?id=121925
------- Additional Comments from jsc@apache.org
set showstopper flag