You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2015/04/08 15:30:09 UTC
svn commit: r1672087 - in /myfaces/tobago/trunk: pom.xml
tobago-pmd-config.xml
Author: lofwyr
Date: Wed Apr 8 13:30:09 2015
New Revision: 1672087
URL: http://svn.apache.org/r1672087
Log:
TOBAGO-1454: Confiure maven-pmd-plugin over a file, to have finer possibilities
Added:
myfaces/tobago/trunk/tobago-pmd-config.xml
Modified:
myfaces/tobago/trunk/pom.xml
Modified: myfaces/tobago/trunk/pom.xml
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/pom.xml?rev=1672087&r1=1672086&r2=1672087&view=diff
==============================================================================
--- myfaces/tobago/trunk/pom.xml (original)
+++ myfaces/tobago/trunk/pom.xml Wed Apr 8 13:30:09 2015
@@ -284,46 +284,21 @@
</configuration>
</plugin-->
- <!-- pmd has problems with annotations -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
- <version>3.0.1</version>
+ <version>3.4</version>
<configuration>
<rulesets>
- <ruleset>/rulesets/java/basic.xml</ruleset>
- <ruleset>/rulesets/java/unusedcode.xml</ruleset>
- <ruleset>/rulesets/java/imports.xml</ruleset>
- <ruleset>/rulesets/java/design.xml</ruleset>
- <ruleset>/rulesets/java/optimizations.xml</ruleset>
- <ruleset>/rulesets/java/coupling.xml</ruleset>
- <ruleset>/rulesets/java/braces.xml</ruleset>
- <ruleset>/rulesets/java/clone.xml</ruleset>
- <ruleset>/rulesets/java/codesize.xml</ruleset>
- <ruleset>/rulesets/java/finalizers.xml</ruleset>
- <ruleset>/rulesets/java/junit.xml</ruleset>
- <ruleset>/rulesets/java/migrating_to_15.xml</ruleset>
- <ruleset>/rulesets/java/typeresolution.xml</ruleset>
- <ruleset>/rulesets/java/strings.xml</ruleset>
- <!--
- <ruleset>rulesets/java/controversial.xml</ruleset>
- <ruleset>rulesets/java/logging-java.xml</ruleset>
- <ruleset>rulesets/java/strictexception.xml</ruleset>
- <ruleset>rulesets/java/naming.xml</ruleset>
- -->
+ <!-- FIXME: currently only possible to build in project build -->
+ <ruleset>${basedir}/tobago-pmd-config.xml</ruleset>
</rulesets>
-<!--
- <excludes>
- <exclude>**/package-info.java</exclude>
- <exclude>org/apache/myfaces/tobago/apt/annotation/*.java</exclude>
- </excludes>
--->
-<!--
- <sourceEncoding>${maven.compile.encoding}</sourceEncoding>
--->
<linkXRef>true</linkXRef>
<targetJdk>${maven.compile.source}</targetJdk>
<aggregate>true</aggregate>
+<!--
+ <allowCommentedBlocks>true</allowCommentedBlocks>
+-->
</configuration>
</plugin>
@@ -791,7 +766,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
- <version>3.0.1</version>
+ <version>3.4</version>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
Added: myfaces/tobago/trunk/tobago-pmd-config.xml
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-pmd-config.xml?rev=1672087&view=auto
==============================================================================
--- myfaces/tobago/trunk/tobago-pmd-config.xml (added)
+++ myfaces/tobago/trunk/tobago-pmd-config.xml Wed Apr 8 13:30:09 2015
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<ruleset name="Custom ruleset"
+ xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
+
+ <!-- TODO: Should this be moved to org.apache.myfaces.buildtools:checkstyle-rules ? -->
+
+ <description>Tobago Code Rules</description>
+
+ <rule ref="rulesets/java/basic.xml"/>
+ <rule ref="rulesets/java/unusedcode.xml"/>
+ <rule ref="rulesets/java/imports.xml"/>
+ <rule ref="rulesets/java/design.xml"/>
+ <rule ref="rulesets/java/optimizations.xml"/>
+ <rule ref="rulesets/java/coupling.xml">
+ <exclude name="LawOfDemeter"/>
+ </rule>
+ <rule ref="rulesets/java/braces.xml"/>
+ <rule ref="rulesets/java/clone.xml"/>
+ <rule ref="rulesets/java/codesize.xml"/>
+ <rule ref="rulesets/java/finalizers.xml"/>
+ <rule ref="rulesets/java/junit.xml"/>
+ <rule ref="rulesets/java/migrating_to_15.xml"/>
+ <rule ref="rulesets/java/typeresolution.xml"/>
+ <rule ref="rulesets/java/strings.xml"/>
+
+<!-- tbd
+ <rule ref="rulesets/java/controversial.xml"/>
+ <rule ref="rulesets/java/logging-java.xml"/>
+ <rule ref="rulesets/java/strictexception.xml"/>
+ <rule ref="rulesets/java/naming.xml"/>
+-->
+
+</ruleset>