You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2009/04/03 01:55:38 UTC

DO NOT REPLY [Bug 46958] New: manager XML interface hard-coded path in XSL transformation

https://issues.apache.org/bugzilla/show_bug.cgi?id=46958

           Summary: manager XML interface hard-coded path in XSL
                    transformation
           Product: Tomcat 6
           Version: 6.0.18
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Manager application
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: photodeus@gmail.com


The manager XML-interface cannot be used if it's installed under any other path
than /manager, failing to find the xform.xsl file needed for XSL
transformation.

Fails:
http://example.com/mymanager/status?XML=true

Works:
http://example.com/manager/status?XML=true

Reason for error, in Tomcat sources
org.apache.catalina.manager.Constants
XML_STYLE returns the constant value 
"<?xml-stylesheet type=\"text/xsl\" href=\"/manager/xform.xsl\" ?>";

The /manager part needs to be modified to match webapp path.

Caller:
org.apache.catalina.util.RequestUtil.StatusTransformer
public static void writeHeader(PrintWriter writer, final String contextPath,
int mode) {
  //...
  // TODO needs current virtual webapp path as parameter
  writer.write(Constants.XML_STYLE);

}

On a sidenote, in org.apache.catalina.manager.host.Constants there is a similar
hard-coded value, which might cause similar problems in the future. It seems to
be unreferenced in the current sources right now (unused value).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 46958] manager XML interface hard-coded path in XSL transformation

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46958


Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Mark Thomas <ma...@apache.org>  2009-04-28 06:19:15 PST ---
This has been fixed in 6.0.x and will be in 6.0.20 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 46958] manager XML interface hard-coded path in XSL transformation

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46958





--- Comment #2 from Mark Thomas <ma...@apache.org>  2009-04-08 04:41:17 PST ---
Thanks for the report.

Since it is only used in the one place I took the simpler option of using a
relative path rather than an absolute one. It also saves having to handle the
unlikely case of the manager app being deployed as ROOT in which case
request.getContextPath() would return ""

I also removed the unused constants from the host manager.

The fix has been applied to trunk and proposed for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 46958] manager XML interface hard-coded path in XSL transformation

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46958





--- Comment #1 from Varun <vp...@gmail.com>  2009-04-05 05:06:28 PST ---
Created an attachment (id=23442)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23442)
Patch to fix this bug.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org