[GitHub] [dolphinscheduler] devosend commented on a diff in pull request #9800: [Fix-#9799] the password echo is empty

[GitBox <gi...@apache.org>]

devosend commented on code in PR #9800:
URL: https://github.com/apache/dolphinscheduler/pull/9800#discussion_r859320110


##########
dolphinscheduler-ui-next/src/views/resource/task-group/queue/use-table.ts:
##########
@@ -149,14 +148,8 @@ export function useTable(
           }
 
           item.taskGroupName = taskGroupName
-          item.createTime = format(
-            parseTime(item.createTime),
-            'yyyy-MM-dd HH:mm:ss'
-          )
-          item.updateTime = format(
-            parseTime(item.updateTime),
-            'yyyy-MM-dd HH:mm:ss'
-          )
+          item.createTime = renderFormat(item.createTime)

Review Comment:
   CreateTime doesn't need to be formatted here, it will be formatted when the table is rendered.



##########
dolphinscheduler-ui-next/src/views/datasource/list/use-form.ts:
##########
@@ -138,9 +146,15 @@ export function useForm(id?: number) {
   const resetFieldsValue = () => {
     state.detailForm = { ...initialValues }
   }
-  const setFieldsValue = (values: object) => {
-    state.detailForm = { ...state.detailForm, ...values }
+
+  const setFieldsValue = (values: IDataSourceDetail) => {
+    state.detailForm = {
+      ...state.detailForm,
+      ...values,
+      password: values.password ? values.password : '******'

Review Comment:
   Password will be hidden by the password type input.



##########
dolphinscheduler-ui-next/src/views/datasource/list/detail.tsx:
##########
@@ -264,9 +264,10 @@ const DetailModal = defineComponent({
                 <NFormItem
                   label={t('datasource.user_password')}
                   path='password'
+                  show-require-mark
                 >
                   <NInput
-                    class='input-password'
+                    class='input-pessword'

Review Comment:
   Why did you modify this class? It may affect e2e



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org