You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/11/12 03:31:13 UTC

[GitHub] [iceberg] chenjunjiedada commented on pull request #3533: Arrow: Fix vectorized position reader

chenjunjiedada commented on pull request #3533:
URL: https://github.com/apache/iceberg/pull/3533#issuecomment-966792576


   > Here is the old logic that I think was causing the issue:
   > 
   > ```
   > if (reuse != null) {
   >   vec.setValueCount(0);
   >   nulls.reset();
   > } else {
   >   ...
   > }
   > ```
   > 
   > We never populated values beyond the first batch when container reuse was enabled (always?).
   
   Thanks for the fix, I think that is it.  Could you please help to add a unit test that reuses the container?  Or do the unit tests in this PR already cover it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org