[GitHub] [doris] 924060929 commented on pull request #18856: [enhance](Nereids): When requiredSlots is empty, prune child previously in ColumnPruning

["924060929 (via GitHub)" <gi...@apache.org>]

924060929 commented on PR #18856:
URL: https://github.com/apache/doris/pull/18856#issuecomment-1516127837

   column pruning has lots of special cases, and can not image all of the cases, so I can not review this pr.
   but in my experience, this code more likely make the regression test, because I remember that I've write the code like you and failed.
   when you run into the bug, you can unify abstraction and modification based on all known cases.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org