You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ignite.apache.org by "Roman Puchkovskiy (Jira)" <ji...@apache.org> on 2022/12/14 11:20:00 UTC

[jira] [Commented] (IGNITE-17167) Simplify the configuration asm generator

    [ https://issues.apache.org/jira/browse/IGNITE-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647048#comment-17647048 ] 

Roman Puchkovskiy commented on IGNITE-17167:
--------------------------------------------

The patch looks good to me

> Simplify the configuration asm generator
> ----------------------------------------
>
>                 Key: IGNITE-17167
>                 URL: https://issues.apache.org/jira/browse/IGNITE-17167
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Kirill Tkalenko
>            Assignee: Ivan Bessonov
>            Priority: Major
>              Labels: iep-55, ignite-3, technical-debt
>             Fix For: 3.0.0-beta2
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> At the moment, the *org.apache.ignite.internal.configuration.asm.ConfigurationAsmGenerator* looks complicated due to the addition of internal, polymorphic and abstract configuration, the code has become harder to read and edit.
> It is proposed to think about how and to divide this class into methods or subclasses for each type of configuration.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)