You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/09/06 04:44:26 UTC
[GitHub] [incubator-opendal] Xuanwo opened a new pull request, #3015: refactor(core): Rname confusing pipe into copy_from
Xuanwo opened a new pull request, #3015:
URL: https://github.com/apache/incubator-opendal/pull/3015
Address https://github.com/apache/incubator-opendal/pull/3008#issuecomment-1707641865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #3015: refactor(core): Rname confusing pipe into copy_from
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3015:
URL: https://github.com/apache/incubator-opendal/pull/3015#issuecomment-1707701028
> writer only accepts a stream.
It's a Reader, not a Stream. And Writer::copy_from a reader seems make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #3015: refactor(core): Rename confusing pipe into copy_from
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3015:
URL: https://github.com/apache/incubator-opendal/pull/3015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on pull request #3015: refactor(core): Rname confusing pipe into copy_from
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #3015:
URL: https://github.com/apache/incubator-opendal/pull/3015#issuecomment-1707658674
https://github.com/apache/incubator-opendal/pull/3008#issuecomment-1707646944
What do your mean? Is this bad? Widely use means acceptable for most people.
And `copy_from` is also a bit wired. It could represents anything, but writer only accepts a stream.
Why not keep `sink`, just short and sweet. And it actually means that it consumes a stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #3015: refactor(core): Rname confusing pipe into copy_from
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3015:
URL: https://github.com/apache/incubator-opendal/pull/3015#issuecomment-1707701599
> Why not keep sink, just short and sweet. And it actually means that it consumes a stream.
I'm guessing you have missed something of our new Write API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on pull request #3015: refactor(core): Rename confusing pipe into copy_from
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #3015:
URL: https://github.com/apache/incubator-opendal/pull/3015#issuecomment-1707731380
I have confirmed your changes. Making modifications only on the raw API is acceptable.
Please update the description of the previous PR to explain the motivation and purpose. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org